Fix infinite loop when creating a graph for a project with cyclic dependencies #183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #184
I am not well acquainted with the codebase. Not sure how those KrateSpans are connected with
bans::check
, just created them analogously to existing tests.Ideally, there should be some integration tests infra. I hand-rolled a test project in
tests/test_data/cyclic_dependencies
just for this case.cc @Jake-Shadle