Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite loop during duplicate graph contstruction #184

Closed
Jake-Shadle opened this issue May 1, 2020 · 0 comments · Fixed by #183
Closed

Infinite loop during duplicate graph contstruction #184

Jake-Shadle opened this issue May 1, 2020 · 0 comments · Fixed by #183
Labels
bug Something isn't working

Comments

@Jake-Shadle
Copy link
Member

We get into an infinite loop when there are cyclic dependencies in the graph...
node_stack grows here indefinitely

cargo-deny/src/bans/graph.rs

Line 227 in 961f381

node_stack.push(edge.source());

Originally posted by @Veetaha in #181 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix infinite loop when creating a graph for a project with cyclic dependencies Veetaha/cargo-deny
1 participant
@Jake-Shadle