gossipd: Do not send warning when node_announcement parsing fails

[cdecker]

Followup for #5897, since node_announcement parsing could result in a warning being sent too.

[endothermicdev]

Is there a specific issue with node_announcement interoperability or is this just to achieve a uniform behavior? The channel_update had a missing htlc_maximum to content with. I think I would prefer to stick to the spec suggestion unless the node_announcement warning is actively causing an interop issue.

[cdecker]

Not quite sure myself, there seem to be some really old announcements that are missing something. I'll see which ones result in a warning based on the historian injector and report back what the specific issue is 👍

[cdecker]

Found at least one:

0101f0841699f108fc110c348e53e4d8d1ce5202c464ce47994bf87f53687b9c570d79f5d6746c67381e1c5b9ba650944cada07a97b89c26db36fc3c17467fd1339c00fd800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002000888252a1638b01b4023e18169f9b4253eff56bd7035660b28c95e61e12fabc03f4aef59d102d55bbb03399ff676f737369706b696e6700000000000000000000000000000000000000000000000001fd21cb47494638396100010001f600000000000505050808080c0c0c1010101515151b1b1b1e1e1e2222222727272b2b2b2c2c2c3232323535353b3b3b3f3f3f4040404646464848484e4e4e5050505757575a5a5a5c5c5c6161616666666969696f6f6f7272727676767878787d7d7d8181818585858b8b8b8c8c8c9191919797979a9a9a9f9f9fa3a3a3a7a7a7a8a8a8afafafb0b0b0b4b4b4bbbbbbbebebec1c1c1c6c6c6cbcbcbcececed0d0d0d7d7d7d8d8d8dededee3e3e3e7e7e7e8e8e8efefeff1f1f1f6f6f6f9f9f9ffffff0606060909090e0e0e1717171818181c1c1c2121212828282f2f2f3131313434343939393e3e3e4141414444444b4b4b4f4f4f5858586060606565656868686e6e6e7373737474747a7a7a7e7e7e8282828787878989898d8d8d9090909696969999999e9e9ea5a5a5b1b1b1b7b7b7b9b9b9bfbfbfc0c0c0c4c4c4cacacacdcdcdd3d3d3d4d4d4dddddde1e1e1e4e4e4eaeaeaf3f3f3f7f7f7fafafa00000000000000000000000000000000000000000000000000000000000000000000000021ff0b4e45545343415045322e30030100000021ff0b496d6167654d616769636b0e67616d6d613d302e3435343534350021f904003200ff0021fe2043726561746564207769746820657a6769662e636f6d20474946206d616b6572002c00000000000100010006ffc09f70482c1a8fc8a472c96c3a9fd0a8744aad5aafd8ac76cbed7abfe0b0784c2e9bcfe8b47acd6ebbdff0b87c4eafdbeff8bc7ecfeffbff808182838485868788898a8b8c8d8e8f909192939495969798999a9b9c9d9e9fa0a1a2a3a4a5a6a7a8a9aaabacadaeafb0b1b2b3b4b5b6b7b8b9babbbc883b302924212023262d35bd862500cccdce00010305080c11182029365a2d1908cfcf02102339c981cbdfe8e805192f543e2407e9e90115c8e57de7f2facd0c2c5130def6c9dbd0e3de9e7c02f75120d72444c27d0b7018cc83f0a13c03339868b0b8cf80b689762a7244372086920f23f721d001b28ec894cf08d833e2625f8008214ea820a1c1c0beff082de9bc6486a3280e1a2f4e6448207041c1223de2c9b3c0b0480a9ff24c0495331440921711f67d3002425f09253a145c7cbad54dd7252504c813c072888f02f2c62ec941206bdb376f97acd0a757880a79097c3439218fc15fb7f29aa04c7780880579289e044427f1f19ac04b7ae04d9751c8e86f02d832998cee84e7cf9125cb232104873c095064c8d3f05a0de82530e4611052339d07283de441e89de6b7121f01d22dff61425e8a284cd125608ec6b992d3cf14081121af459406e908703fe33d895a740884944d67120a847402d69b698fe4fdb7f83fb0f64d7d4f84854e7efa91c1df11e03923de0fe4a5631e14e8a1a35e82632c58840fca0951ff5d3ad74191dd7f1866181b132f0827440b7921171d3ad3950886864478309b1037dc96db6e328641a3103cf445da100d3633806a4b08f88c6b3d7ef1e30f36524644059869264f674d76f1e3612d0ec1a5768a31c1583a8e65e9058d24bc78605d42dcd5a5127cc97396995a9e680458629165165afe7d5300927462d1955147c1a0d488f22800680f58a543d51157e9a355a05c740513003221c1a23e37e5b4930652754869a597e247e0115196facc01558d9a85a5231d509a1219a8ea4c0133b9faaaadcd50c0e612f3a9aac00dba926a6b03133ef1c26629690068b156c0aa8f011ac0e0ce08a13e44010dd0d6c9a900d354738d0a1f61c10db3a88983ff65b78ee800030a230c2342092ce4caeebdf8e6abefbefcf6ebefbf00072cf0c004176cf0c10827acf0c20c37ecf0c310472cf1c414576cf1c51867acf1c656f0e082081a4cc040020610408001093030810622bcc0c3a8286c20f3cc34d7bc81bd4fc46cb3cd2a680103077d3ea40007d64a0143094827adf4d24c37edf4d34ebfec0895164d40c565020d67450e1f149952011fb4ca0406bc96ed4cb98c506dd1a94f60bd8fd653e890819a650790c1af4a906db6d9682fa2f6430f4ce1b63e704721c2007b3f3380084de89db8ad7d2bf2f743c9b69d50e14ee0e0c0e3e83cb0ee118e737e69e4894c9e5099500cae22142f08297a4c452311faeb23918eff88e909f59cfae550a84037edcd04b04212b303ff90ed87e02e5062bb67fdc497c67f333ce8d1d7fe88f2024dea84eae9609e040cbf57cf8c006c0b51bcf8f2206f08f61d3d8b04f7e8787f040eaea3ef0c0162ff70befddfa85f08fbfb60dcf678c78407a444001538810c74e0031fe8400626a8805c46029422ec8f7f67bb5ea908203526c0ef1bf22bc20846220010ec40093b00c1042d32a7215c1083ccf01f210098a7267cf019211c820e1067910610ab0937a8d0430870422b0427210b18050df53100bcbd8f8049d8004722e03e24f4c0400fe9c0158ed81425da6a033684e21174103e7934a08a49e881100522802252818b10f1a2aa02f0b923dcffd01939fc41b00432803a668e87091981111f9244512cf16d1e14a311b2b50fda54810416d94e15e0a88f4286e290fbc05911eed88c1cc6c0220808933bd0a58f59198d9072b4150596c04966e4b0031671a41520f910104c1295864cc80400990e1928a19500c861d0e4110037566107654447036e89c454124e49df88911d1539041e5804375990c0430280462550521e9604c5123110a47db4e389ce3b428a1e22cb2b48ab19e573c237d311ce4f8c1342fb58263a1179840825c4975998412cdf88cb4bf28e51fb989e118019c25a3d44945780ce43c0388579a2a39e9eb82775f6f1a085525308da4c0880b480287dacb2a2051527017d50d26f306993ff1ffdc130a5c3052ce693a0cdcc653a7f003d741c00a242602812bc860e0b7001980018e93f526a4f3132a0911edd691178a90fde6c418a0929004ebba8537eae681f05e86050639acc6f70800bb04cc800b61ac7ae12ae0806d4872d2d13538b68710ba9b2095bf5813a954af5079f64a231857a84b23ee3ac5b482b1ff70a4e67ae8e082195c75dc7fad721509547577d8856519a5383569606fb104055086b04a27ec3a85bb8c0432ac359ae7ad6ab74d547068640da22cc141d15d4824df9ca587a3ab67b47b8816103f091da1261b788e1424bd371d25376d6afb025c246f45101ca46d785db04aa150ceb0c8a3ad7b5d07deb1172b0c2211977080e79ff8829ad005a76f6f6a2bf8d5f12149b0edc9c97382cd4c23b9911bba53eb7a9951dc20e2efb0c18dcf7073ba89a162660916e7e8fa9198da910d22b0f071cf807cb3d9058a9c083f2f2f6bddfc06827346a45d332a351e23d02072ca2bd2a7c2821c701f13344cc0912238196b6caa145d1d1d12adc161d006d6d5b5f9b6224f8809429c9238af7f1d2298c2921ac95b13368bc091b230105bcca2334e5813f2ac4e9212118e47f231c6023fcf82179cc01779df100ed32c107714d48009c08851dcf38be206cc2605495c71f38f421157073127c8049007857cacda0b226ac9c843526792f1ede0704f287841cdcc7224ddc2284472ce122acf3527dfe0185ff87380234f66004f50b2416ec3c653ce3b040a50af50f3637120264805c61f2810d54800102ef2370abde748d3b5d04dd80ba0936f0f536d7ccc41f6a7acc9c2e33122870ec26b880d9a20bc039830ded614bfb0835a8f662600880ccf84cd85526b6115ef8d8c560db6c0130f7b9bb9dee6fcfefdd9d8c020b22fdba01542e0bac4eb4abf12805ac7244d645b0c1538dc700197e77c8e16db713763812846fc803f8e688003c20e8678317c0d795cdc1ab7083423fc4027e9cf7c7c91c722694d3221647c20d38a06c8b108003ce0643c099a1e84c30da09fe5477137cc0020c2c392106c8400b3ace859d03a0e7fec2c10a3e70810720a000030840340a90ff80075ce0032b4839c7c64ef6b29bfdec684fbbdad7cef6b6bbfded708fbbdce74ef7badbfdee78cfbbdef7cef7befbfdef20a1410a4a1082109000052f7078c37a1a3c010ce0000b8040064400836e321e00eb158281f9cd8c0030000328f8e1c27905ab0010e0000fc8000a8c5984cbcfeaf2ce30fd011c700112e49c08ae4f4264133d7a5bedf71901b802ece76281781a061debdd816a2d12fc1ff45e55bfeffcdd8e90fbe38fe401e5abfe1176cff3e7972afac113fea5264069edff8007ded7abf3cd067e66e0ca08da1ffe3e5a68fd67647e08dc7f7afa61d27e6888ff5204d05f42b067f64704d43612cdb77f29d17f0060001b167fa5b26d3f4080ffce707f2015620a3812fdd77c55207f021100ffa67d4e077c4290811cc1800010635e827c2b7829e14481cd60813f907f0b60822c04131c480597870009900007c079cd2000dcd28205683edf100017b0023480033730035317012fd27c14d08354488548c6755558852fe60c1590015e48018cd40c4ac5532c587fce60022f90862e50028ed60ce5627e4540835398853d78857448855b288677588550b704e697032b803d0a204ada7774ff46043cb00212802049601bdf407fad5786439087cdb02eda0783cc907907f80c214286df208334d888e80089b82789600087425003fb27486618836df20dfab40462571ba39804a8783e41e68945a88b156804ff02f50dacc88bae8804a188048ef80ca44884bd2806a828043d406bab1226d59703df006c57708cce908cad9889f0870e2e508a9fa88cc3480409f688e2c88dc41862a2688e48d08c5c80899897043a906acc704ed5578ece20008aa704d8d80cda288ce848049fe60ca70281e15804bff80cc9e28e33a88ec6588bed688a5f008f321820e8a017da176906500274f604fdc80cff888a2c800ebf6290bb3804a633001dc490c5383f1079041439060cf90339f20d0eb08df1280497765119600215f990ec487d12f903f4c50c92748e3909900080866a6802d0e80c93a594a0e8902e1994ddf81f7b48859ad43b43590461b859da87657c24011c99392f7995ff27f903347059c18893af77291200512c499546f09100109230918b5330933f1067cee09676d186c48401b3488b561989df20022ab09825700191b60040659298360291d99517786740898cb69897ff979646b089ce7042e6870348260f03a05099998d9b99120a504792593543889453899955a99948008f02a19752c097a0d90ca229913b6072dfb88eb629941ad7011b06983829679d2895ba4797456097789912ba19057ce9979da79c451003160084cf60001d279dabf91002600282f69a1c1100b13397b4599767899823519d5c79904970746069993fd0032ee0010fe09de5469caa199123d1007e1493da797e06065f03889ff9d757d1f99ee0e899ff5d309336800e37e99c6f160320705b1700a0fe389e1c8100ac378192d88c45c90cf5b129cf209f3f805c175a9b016a9c12ca053379a2008091f889044fe60cb1e89e8719a1bda86b23e035d5059fcb88a145c003e1136680850e1258044fc90cd804a31f2aa033ba050c99030456347c493dcf70943e5a9c6879a434797400309cb299a647404a5a136e2e950445825a540a92203a8ea768996ae453d228894c4704944865e269a564fa032aea0c0e8a9e49590447875a12f50cb335a700c0a4903a9d57aa05cd58030b900ec1a87d0c6042ab114d1e4aa7826aa797f90ca889a8f75793cfe05d510a006175047bd40c4f4a04810a93399a05e6a7032c2088ff842889f1300019607c3f60034572680ffaa36a4a04c6f60c7d85aa467045e8108c5bd6a1c57659a911aa7759a70179a7ffa1000a8000f4080eb189a4d972001650022f40033970032e4073e8e00fa959a5323aa8a5ea0c0b59a2e8c09469c80220509a33810365c40025100333c0021a5046c67aac626aa462e8ad0efbb00e8b9abb394721e8ab9772005554ab634aaa421058cf108b886a11d66884302100b7a7b031bab12c66051ea80f0430abda17860f216f939a04066a04c875a6da899b092184499a61fbd062353baa2bdb81e3577e169b128885ad944aaf9a67a1dad9b2e9300002988a32ab0f2ac8b4dafa10426b9d245401c2aa7d2390a9162100bced14afa23aaf1c3b043be90ced10b29c72019426043bc0605925b1689bad44cbb52c3b178f177993f702962791363002146062090002738bb2f2aab2895a04f31438701b3ca7977aabd704336074f3d00026e06086b9b040ca115d0b083a1003832702c470022f30a2a870032b6002221002259002950778b67bbbb89bbbbabbbbbcdbbbbefbbbc01bbcc23bbcc45bbcc67bbcc89bbccabbbcccdbbccefbbcd01bbdd23bbdd45bbdd67bbdd89bbddabbbddcdbbddefbbde08bbd41000021ff0b496d6167654d616769636b0e67616d6d613d302e3435343534350021f904003200ff002c00000000000100010007ff800082838485868788898a8b8c8d8e8f909192939495969798999a9b9c9d9e9fa0a1a2a3a4a5a6a7a8a9aaabacadaeafb0b1b2b3b4b5b6b7b8b9babbbcbdbebfc0c1c2c3c4c5c6c7c8c9cacbcccdcecfd0d1d2d3d4d5d6d7d8d9dadbdcdddedfe0e1e2e3e4e5e6e7e8e9eaebecedeeeff0f1f2f3f4f5f6f7f8f9fafbfcc8044c51aa60c96265ca9323fd8c51f9c1b0a1c31f73e2c069a3a64c982c5112687a02a6cdc38772cc58219230d8c28f2851c201d38412902a6e52a69ca30261c95e2765ea6ca8064a24261e77caf412e4e6ae9c4277ae20d9084bd29d6b8a18cd85f4a9cc3749187db1baf38dc6a9b6aa7245196789222d6377b61902b696d8b40fff77d834e464e79c3258a454a8f2e5cdce326d69bd6558a47011244da480b121744dd1424162ca14c3b45014bf32a7049635f847a22665766a31944527154543d85c7dbcd955e74554e4c894c37610103832472f22b22373eb57af1751d0a95b500599368034922253cd6fd7321ba14de986901899171e054529f5f9aae08b82e04e9955d0f88f7258339a8e528af7efd1a5cbac22a8884c329094c8fcf25e15f8454cc814862075a5b4052441c864467fa9fca7081073a4b4200053c81445248ca1640383a838a8c8790fb121c815323d11491a29edc0e1291e26a21a4a6d08525a4a664162464a72ac684a8b88bcf8518c00b0f7518d8f8486528e3a92c2e3ff21203a24220024a664222428a2a46292a32c5908100a0a52614a174292e18f5866191f234d0828c813b92118214a1396098a96846c319f2046dc97df7e728642a72042f446de204d3614877a8b08f9907b7d7ef22700765247880ad8692753778d76f2e7716d0ec2a986ca31c25c4ace65ea099d55bc79646d82dcd6a922bcc9749aa99a9e690868a291661a6a3e7e0407a2b462d299618731a1d89832b1016c1098a544d92197e9a459b09c7406d70f7221c2a64e77e5b5d7179275496db5d7e248e4219196fb901b958d9b89b563b9519e2260a8eb101c73b9fbaebd0dadc0ea2233aacb8611fa926b6f1a533ed2c476697d016cc196c0abd31b5f30e192ff15e13eb5021210d7caad1c13557451055f61c211c3e8898469c7ce0cc1c405560c74051550e4cbf2cd38e7acf3ce3cf7ecf3cf40072df4d044176df4d14827adf4d24c37edf4d350472df5d454576df5d55867adf5d69608e1c4155f8ca1860d6fecb0c31b36a831c617573421c4b8177821f7dc74d7ed85cd8fc46db7dd1568c24417bd3ec54617164bc204158827aef8e28c37eef8e38ebfed0ca5568d41c975420d6809115a149a161c5ab4cb4818fc96ee50c9cc506ed5b98f60be93e6930c0186aaa5cf01c6bf8a906ebae9a82fa3fa53674ce2ba4eb04772451cbb3f14c7158de89ebcbdbd2bf3fb5309b79e54f18e1481c6f3289db1f221ce737f6dfff4c94c9f54a9900caf26244d082a7e5c852312fefb63918f8cf949f59dfef59054403bfd0d99030512313f003ec57ec7c09f5092b3bfcc3de25306fcc800c117c1fa3d438142999623d49712ec258209ffab2043e4c03a411450843241a03130d8958721828328f1e0218ae03e143a6407a203c0096df811151683853b61de06f9c78833a4450e2a908212860004200c41095350816cc6029842ec9087a7bb60b976203946c0f023322c8415c622872c10401104c8c214ad32ab415c118b0cf121318098ab467cf121611cc4109067953410ac1146a8d2537670464b0428296b18071d751207dcbd908889f00257cae0424404c1484fe1c2250ed91845dacbff0b7684e42186104299a4a192890882208522874252829350f1a4bae6f0bd43dcd121790440c08412875a668f8f49b182219f9248712cf2755e14a52132b613fa54a20a56d9502560a9936286e3983bc15b216ed9903c2ec12a6d08954b50a69379198e98b2b4d70a16c14d86e4910b5671a625a0f9942c4c139dc64cca188099122528a29d3fc863e064320757568200a544491aee89c874124f511f89932d9539082158053f9920c353e6804a45505326d604c722c310a89db4e4910e3c449a9e22cf4b48ac212574c4475312d26f8c144a3b59284a9179882825c59f9948423c5f89cf6bf28f593b99a021001ac67a3d459c9780d05340398999a2a4a6deffb8298576f2a4a55254101a4d0a9034812c9dacb3aa451529118150d68f306a9b5f05c04025c4094ce694a80dcd674a01004194b801aa82602a223c8712317002a03f18eb4fd26a5351aaa1995edd6b21f8a913fe6c42924981035e3ba9579eae692770e86260e39ad08f748113f04c4a1c361bcbce12af1046d4893dad1357ab687213e9b20b6b75823eb54a1600df64a441057b88d23ee4b49b482d2f770b5287ae8f106195c96d47fbdb4150964f977d8a66d19a57a35617093b914365886b08c27ec4b09b40c153aac35dce7ad7b3b4d509180641de42cc152555d4845d79cb5c9a3ab78387308271e7f095fa1262bfc8e1445b5372d67376d7b7f025c4ff5674a202ea46d88d1b05ac258ceb10aa3ad8bd107eed2188b0c6411978104e798a392d015e96f6f7aaff8d6122949b12fc9c98406cd4c44b1912bfc53eb8b1d51d0401aefb1026dc180004a89c26c660958e7e90b1598dab20522c13341c19000b3e926829218412f3f7c51fc16a37b46a49f332a459223e4417aca2c14a7c29290702f343c4cc0d3223829ef6caa35551d2d54adc1725406d6f6bdf9b664400819c69c9259a77f2d6498c2a29ec95b343e8bc0d3b23e202fcca25446582434ac4ea295818e68fa31c6443fcf929b92402871d72060d330208b14dca1c1c09893dcf39c6606cc470d4954b0038f5292a7075228080cd1f7858d20da1b4362cff9d8855267a375ede891972880822dcc82a8ddc2494c72ce542acf45abd0600950769055406c10a350c26266c3d695ce3b148e50a3700b637961d808164a10242022a100622ef2478ebde769dbb5d08fd80bb1109f0f74657cdc83f6a7bd4dc2e35225670f0463881e1e29bc349030ef1814bfc1047a8f872e0f883ecf84de09526b821def8dce560dc747330f9c93b9ef28fcff0e5dd8c0414a2fdbe38542f13ec4eb6bb712909cc7245de8548c0630da806397e78d0216eb923f63816a46f690b38e78a1cb620ec878318c81796cfd12b6184623f450cbe9cf9d7491d764694d42a56478411baa070abeca00b0e0745d019a2ec6c30db113e557923800085ff302c3a296f00c313bace89bdffa0ef3e2b0205b4808233b4010e71984344e0608333a0400b14483bd7464ffad29bfef4a84fbdea57cffad6bbfef5b08fbdec674ffbdadbfef6b8cfbdee77cffbdefbfef760414214a880052c54e1024d707ad3fa1a4039c4c10d6b300318aec0848e32ff072b16849179ce9039a8210c17f8e3d2f905af39ecc00d6700c3050c5a88ebcfebfa0e31bf1bd080822ae49d10ee4f4474933d7e7bedf821737009f0371b621053c681122b4600ea6515010800fda72effd77db77308f9778063710625548187b07f7cf780e51281012480d73206d4a6810020041ea85b0e683a20c810f862081a38803bd14616f810d937081cf8ff782908172d081122782d3bd06382b06b3648081437160db88369d1833ff0065b1683e5b2710040840e71836015664a38163dd8809520834231073fa7818e07808290855cc1843f10679e82806b782d2145850d61850090836b60866c04175c4809d7d7063660036ec07d0d21071cd3864568421f31072840014850044690049357066fd2802bd08794488988c6799558896fe6102a00069eb802ccd4108ac5576c58830e31054d908a4e4005ced6102563828540879398897d7889b448899b288ab7588990b7082648041480416c204e1a78783f470842400164802489601f1f4183ed578a83908b0db1321a08870c917d47f81061428a1f218774d88c2801ff8df8278da0008b8270043b284ca61887adf2113ab508a2571fe39808e8784281e68d85a88f55680842f511ecc88fee8808e18808cef810e44888fd280ae8280841406feb122a1548041f01709770900e9190ed988d3088124e508edfa89003490849f68c22c991041966e2689288d0909c808dd8970843906e0c71521558920e2107caa70818d9101a2990284908dfe610e70285215908fff81009e39273a89206598f2d698e9f009372182428a11b1a186d6f4005b4f6083dc9103f898e508012ff6294fb3808e613075dc49405394350790854390a4c090079f21168b091312908d7765560300555f9942c498152090034c610d274927909943f808aaa38ff0510e910d3a598e0e8946e19981df923bb4889dad43f835908a1b85d1a8869bc44065c993d6f799967090048705d018997ef772d6400556c499986f0953f109670918f93309700106b0ee19ab6d18a041506f3488f96198d1f710515b09c548002d1b606806596d86605d1d99957786b808990f6989b3f989a86b08d0e714626580488261371a054d99991db99166c504bd2593983889893899d95a99d88009342a19b92c09be0d910e229950460761fb992f629985ac7055b069c78296bdd2899fa479b85609bb89916fa1909bce99bdda7a085b0046200880ff1065d27a1ebf914723005c2f69e5c3107f1339bf4599ba7899c6351a19c7994897078a069ff9d0010044eb00567e0a12547a0ea1995639106be14971a7a824606634388a339d85b11faa220e99d9d309709801277e9a0afb60459705f2800a43e39a25cd106ec3785d2d89085c91035b22d0f21a3008060575a9f416aa052ca097379a63f8095388a088fe610f1e8a2c719a5fda86f56e0391506a30b89a585200421146ac085125258088fc9101805a75f2aa473ba094c4904445638bc49410f71987e5aa0a879a87479783f30a0f299aa87404e9a13726e950885825e940a96603a92e7689daae45712298d8c4708d44869226aa9a40a006aea104e8aa289590887875e52f510f335ab3fc0a8d03aa197aa090d79046b901201a9816a6046eb11515e4affabc26aabd7f910e889ac3758970fe16191fa03a17508bbd4108f4a08c10a97799a0926380450208cc4288d31110760608000900085726c4ffaa7aa4a0806f710bd85ae8670492811909bd6a505775de911aeb759ab4179ab3fc2066cd006340912f189a819e3066240054d80044460044e407728e113e959a9723aace5ea104b59a628c198a9080559509e735104a5a40654b0044900055f504a067bb0a26aa8a2e8b14efbb44e8b9efb394b61e8afd7e2069554afa34aae82105c0f118fc86a15166988702107f7a7b471bab56c66095ea8133b30af1a188a4f2173d39a08466a080876aa1a8a9f492188899a653bd166753bae6bdb85235882569b16c885e4b1d44ab3da67a51adab629110742988e72ab136ac8b81afb14826ba164a40202ab815690ad5621072d15b3e23ab35c3b087be9102d11b6dc8202d4260804c0649925b5a89bb184cbb96c3b1bcf177dd3d704d627950960052b6066369005b38bb632abb6c95a0833153cb01b40e7977eebd70849607833910653e064c6b9b480ca159d0b0c43b004c377050421054d30a6e86004143005578005541005d5077cf67bbff89bbffabbbffcdbbffefbbf001cc0023cc0045cc0067cc0089cc00abcc00cdcc00efcc0101cc1123cc1145cc1167cc1189cc11abcc11cdcc11efcc1208cc18100003b

And decoded:

WIRE_NODE_ANNOUNCEMENT:
signature=3045022100f0841699f108fc110c348e53e4d8d1ce5202c464ce47994bf87f53687b9c570d022079f5d6746c67381e1c5b9ba650944cada07a97b89c26db36fc3c17467fd1339c
features=[800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002000888252a1]
timestamp=1670054324
node_id=023e18169f9b4253eff56bd7035660b28c95e61e12fabc03f4aef59d102d55bbb0
rgb_color=[3399ff]
alias=[gossipking 676f737369706b696e6700000000000000000000000000000000000000000000 ]
addresses=[ ]
tlvs={
type=1
len=8651
(msg_name=option_will_fund)
lease_rates=funding_weight=18249
lease_fee_basis=17976
channel_fee_max_proportional_thousandths=14689
lease_fee_base_sat=65537
channel_fee_max_base_msat=**TRUNCATED tu32 node_announcement.tlvs.lease_rates.channel_fee_max_base_msat**
**TRUNCATED TLV node_announcement.tlvs**
xargs: /home/cdecker/dev/lightning/devtools/decodemsg: terminated by signal 11

So we sort of assume that the lease announcements are correct. Rejecting is likely still the correct response, but we should also suppress the warning until LND knows how to handle them (I assume it's mostly a deployment thing rather than the speed for them to implement).

[endothermicdev]

Thanks for verifying!

ACK 4e77168

[cdecker]

Ok, found a couple more failures where decodemsg fails:

Total population:

 281513 channel_announcements_decoded.txt
17887788 channel_updates_decoded.txt
2802955 node_announcements_decoded.txt

Failures:

Type	Failures	Total
channel_announcements	0	281513
channel_updates	15456	17887788
node_announcement	9	2802955

I can check these again against newer snapshots as the network evolves. And the warning can be re-introduced once lnd doesn't get as upset about it.