Skip to content

Commit

Permalink
gossipd: Do not send warning when node_announcement parsing fails
Browse files Browse the repository at this point in the history
Changelog-Fixed: gossip: We removed a warning for old `node_announcement` that was causing LND peers to disconnect
  • Loading branch information
cdecker committed Jan 26, 2023
1 parent fa4b61d commit 4e77168
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions gossipd/routing.c
Original file line number Diff line number Diff line change
Expand Up @@ -1848,10 +1848,12 @@ u8 *handle_node_announcement(struct routing_state *rstate, const u8 *node_ann,
* - MAY close the connection.
* - MUST NOT process the message further.
*/
u8 *warn = towire_warningfmt(rstate, NULL,
"Malformed node_announcement %s",
tal_hex(tmpctx, node_ann));
return warn;
/* FIXME: We removed a warning about the
* node_announcement being malformed since the warning
* could cause lnd to disconnect (seems they treat
* channel-unrelated warnings as fatal?).
*/
return NULL;
}

sha256_double(&hash, serialized + 66, tal_count(serialized) - 66);
Expand Down

0 comments on commit 4e77168

Please sign in to comment.