connectd: better diagnostics on invalid gossip_store entries. #5573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should help diagnose ElementsProject#5572 which hit the invalid csum on a >64MB entry, if it happens again. Signed-off-by: Rusty Russell <[email protected]>
endothermicdev
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
I guess this will tell us if it's purely an offset issue as opposed to something like a bad length / length mask. We may also want to validate the message length/CRC before returning the find_gossip_store_by_timestamp offset as gossip_store_next traversal was a little more thorough. Maybe that's a another PR.
ACK c90d798
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help diagnose #5572
which hit the invalid csum on a >64MB entry, if it happens again.
Changelog-None