-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crash in connectd due to bad gossip_store #5572
Comments
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this issue
Sep 5, 2022
Should help diagnose ElementsProject#5572 which hit the invalid csum on a >64MB entry, if it happens again. Signed-off-by: Rusty Russell <[email protected]>
This was referenced Sep 5, 2022
niftynei
pushed a commit
that referenced
this issue
Sep 7, 2022
Should help diagnose #5572 which hit the invalid csum on a >64MB entry, if it happens again. Signed-off-by: Rusty Russell <[email protected]>
endothermicdev
added a commit
that referenced
this issue
Sep 9, 2022
Work in progress to help diagnose #5572
niftynei
pushed a commit
to niftynei/lightning
that referenced
this issue
Sep 13, 2022
Should help diagnose ElementsProject#5572 which hit the invalid csum on a >64MB entry, if it happens again. Signed-off-by: Rusty Russell <[email protected]>
niftynei
pushed a commit
to niftynei/lightning
that referenced
this issue
Sep 13, 2022
Should help diagnose ElementsProject#5572 which hit the invalid csum on a >64MB entry, if it happens again. Signed-off-by: Rusty Russell <[email protected]>
endothermicdev
added a commit
to endothermicdev/lightning
that referenced
this issue
Sep 14, 2022
The gossip_store version byte was unaccounted for in the initial traversal of gossip_store_end. This lead to an offset and a bogus message length field. As a result, an early portion of the gossip_store could have been skipped, potentially leading to gossip propagation issues downstream. Fixes ElementsProject#5572 ElementsProject#5565 Changelog-fixed: proper gossip_store operation may resolve some previous gossip propagation issues
niftynei
pushed a commit
that referenced
this issue
Sep 14, 2022
The gossip_store version byte was unaccounted for in the initial traversal of gossip_store_end. This lead to an offset and a bogus message length field. As a result, an early portion of the gossip_store could have been skipped, potentially leading to gossip propagation issues downstream. Fixes #5572 #5565 Changelog-fixed: proper gossip_store operation may resolve some previous gossip propagation issues
whitslack
pushed a commit
to whitslack/lightning
that referenced
this issue
Oct 8, 2022
Should help diagnose ElementsProject#5572 which hit the invalid csum on a >64MB entry, if it happens again. Signed-off-by: Rusty Russell <[email protected]>
whitslack
pushed a commit
to whitslack/lightning
that referenced
this issue
Oct 8, 2022
The gossip_store version byte was unaccounted for in the initial traversal of gossip_store_end. This lead to an offset and a bogus message length field. As a result, an early portion of the gossip_store could have been skipped, potentially leading to gossip propagation issues downstream. Fixes ElementsProject#5572 ElementsProject#5565 Changelog-fixed: proper gossip_store operation may resolve some previous gossip propagation issues
whitslack
pushed a commit
to whitslack/lightning
that referenced
this issue
Oct 28, 2022
Should help diagnose ElementsProject#5572 which hit the invalid csum on a >64MB entry, if it happens again. Signed-off-by: Rusty Russell <[email protected]>
whitslack
pushed a commit
to whitslack/lightning
that referenced
this issue
Oct 28, 2022
The gossip_store version byte was unaccounted for in the initial traversal of gossip_store_end. This lead to an offset and a bogus message length field. As a result, an early portion of the gossip_store could have been skipped, potentially leading to gossip propagation issues downstream. Fixes ElementsProject#5572 ElementsProject#5565 Changelog-fixed: proper gossip_store operation may resolve some previous gossip propagation issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We hit an assert as we try to send a giant status message (> 128MB), but the reason we're sending it is because a gossip_store entry fails checksum. I accessed the gossip_store shortly after this, and it seemed fine.
The most likely explanation is that connectd somehow got a bogus offset, and was reading junk from the store.
The text was updated successfully, but these errors were encountered: