Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: fix typo which can cause build failures. #4028

Merged
merged 1 commit into from
Sep 9, 2020

Conversation

rustyrussell
Copy link
Contributor

@rustyrussell rustyrussell commented Sep 9, 2020

And add secp_recovery to headers, while we're at it.

./wire/wire.h:7:10: fatal error: secp256k1_recovery.h: No such file or directory
 #include <secp256k1_recovery.h>
          ^~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
Makefile:254: recipe for target 'connectd/test/run-initiator-success.o' failed
make: *** [connectd/test/run-initiator-success.o] Error 1
m

Changelog-None

And add secp_recovery to headers, while we're at it.

```
./wire/wire.h:7:10: fatal error: secp256k1_recovery.h: No such file or directory
 #include <secp256k1_recovery.h>
          ^~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
Makefile:254: recipe for target 'connectd/test/run-initiator-success.o' failed
make: *** [connectd/test/run-initiator-success.o] Error 1
m
```

Signed-off-by: Rusty Russell <[email protected]>
@rustyrussell rustyrussell added this to the v0.9.1 milestone Sep 9, 2020
@ZmnSCPxj
Copy link
Collaborator

ZmnSCPxj commented Sep 9, 2020

ACK 1aef8ab

Travis is complaning though...

@rustyrussell
Copy link
Contributor Author

I killed travis. Not worth it for this (I let it test the builds though).

@rustyrussell rustyrussell merged commit c76cfe9 into ElementsProject:master Sep 9, 2020
@jsarenik
Copy link
Collaborator

@rustyrussell The same error happens even on current master (70977a4) when compiling with make -j4 and no secp256k1_recover.h already in include dirs, so it is ordering issue of the submodules initialization. If the submodules would be initialized at once as the first step, it would not happen.

~/src/lightning$ git clean -xffd
...
~/src/lightning$ git submodule deinit --all --force
...
# Now the repository is generally in a fresh-clone state
~/src/lightning$ git describe
v0.9.2-23-g70977a4fb
~/src/lightning$ ./configure && make -j4
...
In file included from bitcoin/block.c:8:
./wire/wire.h:7:10: fatal error: secp256k1_recovery.h: No such file or directory
    7 | #include <secp256k1_recovery.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [Makefile:266: bitcoin/block.o] Error 1
make: *** Waiting for unfinished jobs....
...

This error is not noticeable on long-living git repositories which have the file external/libwally-core/src/secp256k1/include/secp256k1_recovery.h present.

@jsarenik
Copy link
Collaborator

The new issue #4229 is tracking some historical appearances of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants