Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsecp256k1_recovery.h missing #4229

Closed
jsarenik opened this issue Nov 26, 2020 · 2 comments · Fixed by #4234
Closed

libsecp256k1_recovery.h missing #4229

jsarenik opened this issue Nov 26, 2020 · 2 comments · Fixed by #4234

Comments

@jsarenik
Copy link
Collaborator

jsarenik commented Nov 26, 2020

Issue and Steps to Reproduce

See #4028 (comment)

Worth noting is that even when the error shows and part of compilation is terminated, make waits for the rest, the rest seemingly finishes, but the return value is 2:

# Put repo in clean state (like if it was virgin-cloned)
~/src/lightning$ { git submodule deinit --all --force; git clean -xffd; } >/dev/null 2>&1
~/src/lightning$ git describe
v0.9.2-23-g70977a4fb
~/src/lightning$ ./configure && make -j4 && make PREFIX=$HOME/lightning-my install ### let it finish
...
~/src/lightning$ echo $?
2

This is pretty bad for scripting. In other words the make install part was not run at all because make -j4 ended with 2. But also the compilation is not finished really (just checked lightningd/lightningd is missing).

@jsarenik
Copy link
Collaborator Author

See also #1538 (comment)

@jsarenik
Copy link
Collaborator Author

See also #4028 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant