chaintopology: set a fee floor to avoid creating unrelayable txs. #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naively, this would be 250 satoshi per sipa, but it's not since bitcoind's fee calculation was not rewritten to deal with weight, but instead bolted on using vbytes. The resulting calculations made me cry; I dried my tears on the thorns of BUILD_ASSERT (I know that makes no sense, but bear with me here as I'm trying not to swear at my bitcoind colleagues right now). Fixes: ElementsProject#1194 Signed-off-by: Rusty Russell <[email protected]>
|
I think this is the more general fix than #1247 in that it fixes all transactions we generate. |
ZmnSCPxj
approved these changes
Mar 20, 2018
| u32 feerate = satoshi_per_kw[i]; | ||
|
|
||
| if (feerate < feerate_floor()) | ||
| feerate = feerate_floor(); |
There was a problem hiding this comment.
Suggest adding a log_debug here that we are bumping the feerate up because hsyterical raisins. Or alternatively expand the existing log_debug message that we bumped it up and the actual feerate received from bitcoind.
|
ACK c059b8d |
…floor. But only if we're actually going to change the feerate, otherwise we'd log every time. Suggested-by: @ZmnSCPxj Signed-off-by: Rusty Russell <[email protected]>
|
ACK 1d3b056 |
|
Amusing: |
|
Fixes #1210 |
|
ACK 1d3b056 |
Closed
Closed
This was referenced May 24, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naively, this would be 250 satoshi per sipa, but it's not since bitcoind's
fee calculation was not rewritten to deal with weight, but instead bolted
on using vbytes.
The resulting calculations made me cry; I dried my tears on the thorns
of BUILD_ASSERT (I know that makes no sense, but bear with me here as I'm
trying not to swear at my bitcoind colleagues right now).
Fixes: #1194
Signed-off-by: Rusty Russell [email protected]