Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum acceptable fee rate seems very low #1391

Closed
sstone opened this issue Apr 18, 2018 · 4 comments
Closed

Maximum acceptable fee rate seems very low #1391

sstone opened this issue Apr 18, 2018 · 4 comments
Assignees
Labels
eclair-compat fee state::fixed These issues should have been addressed. Pending confirmation by OP, will close soon otherwise state::stale This issue/PR has not seen any activity for a while, and has no actionable step. Will be closed soon

Comments

@sstone
Copy link
Contributor

sstone commented Apr 18, 2018

Issue and Steps to Reproduce

Our eclair->c-lightning channel with 02f6725f9c1c40333b67faea92fd211c183050f28df32cac3f9d69685fe9665432 gets closed very often after sending an update_fee message because c-lightning thinks our fee rate is too high.
Here is the last instance:

2018-04-18 13:49:41,721 ERROR fr.acinq.eclair.channel.Channel akka://default/user/$h/switchboard/peer-02f6725f9c1c40333b67faea92fd211c183050f28df32cac3f9d69685fe9665432/$b bbd26dbcaea03b0425f1e8c237de3b9cae1795a333d4a415ddfb814ba467d353 - peer sent error: ascii='update_fee 11008 outside range 253-6300' bin=7570646174655f666565203131303038206f7574736964652072616e6765203235332d36333030

We use bitgo to estimate fees and check every 10 minutes. We got a fee estimate of 43 sat/byte ~= 43000 sat/Kb ~= 11000 sat/Kw
We checked right away with 2 different bitcoin nodes which have been running for a long time and got:

bitcoin-cli estimatesmartfee 2
{
  "feerate": 0.00014278,
  "blocks": 2
}

Which gives 0.00014278 btc/kB = 14278 sat/Kb = 3569 sat/Kw

My understanding is that c-lightning will accept up to 5 times the fee estimated by the bitcoin node it is connected to, it does not seem to be the case here

getinfo output

N/A

@redstorm1
Copy link

Are these errors also related?
2018-04-24T01:45:44.361Z lightningd(7877): 037ea3a8984c2eae56766b45a528e924c10944b2111d5c19a2ca96962ea380496a chan #35: Opening channel: sent ERROR feerate_per_kw 250 below minimum 253
2018-04-26T01:26:29.806Z lightningd(7877): 038863cf8ab91046230f561cd5b386cbff8309fa02e3f0c3ed161a3aeb64a643b9 chan #36: Opening channel: sent ERROR feerate_per_kw 250 below minimum 253

@ZmnSCPxj
Copy link
Contributor

@redstorm1 that is a side effect of the #1251: our minimum is 253 so that we will not violate bitcoind minimum, due to a difference in fee calculation between what is actually specified in the BOLT, and what bitcoind uses. I am unsure but maybe other LN software does not follow the calculation specified in the BOLT but instead uses the bitcoind calculation.

@ZmnSCPxj
Copy link
Contributor

ZmnSCPxj commented Jul 9, 2019

Is this still an issue in practice?

@ZmnSCPxj ZmnSCPxj added the state::fixed These issues should have been addressed. Pending confirmation by OP, will close soon otherwise label Jul 9, 2019
@ZmnSCPxj ZmnSCPxj added the state::stale This issue/PR has not seen any activity for a while, and has no actionable step. Will be closed soon label Aug 5, 2019
@ZmnSCPxj
Copy link
Contributor

ZmnSCPxj commented Aug 5, 2019

Marked as stale and closing due to inactivity. Please re-open if still an issue.

@ZmnSCPxj ZmnSCPxj closed this as completed Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eclair-compat fee state::fixed These issues should have been addressed. Pending confirmation by OP, will close soon otherwise state::stale This issue/PR has not seen any activity for a while, and has no actionable step. Will be closed soon
Projects
None yet
Development

No branches or pull requests

5 participants