Support URL objects in HttpServerResponse.redirect (#4154)

Effect-TS · Dec 18, 2024 · 05d71f8 · 05d71f8
1 parent e66b920
commit 05d71f8
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/gorgeous-buttons-help.md b/.changeset/gorgeous-buttons-help.md
@@ -0,0 +1,5 @@
+---
+"@effect/platform": patch
+---
+
+Support URL objects in HttpServerResponse.redirect
diff --git a/packages/platform/src/HttpServerResponse.ts b/packages/platform/src/HttpServerResponse.ts
@@ -88,7 +88,7 @@ export const empty: (options?: Options.WithContent | undefined) => HttpServerRes
  * @since 1.0.0
  * @category constructors
  */
-export const redirect: (location: string, options?: Options.WithContentType | undefined) => HttpServerResponse =
+export const redirect: (location: string | URL, options?: Options.WithContentType | undefined) => HttpServerResponse =
   internal.redirect
 
 /**

diff --git a/packages/platform/src/internal/httpServerResponse.ts b/packages/platform/src/internal/httpServerResponse.ts
@@ -98,10 +98,10 @@ export const empty = (options?: ServerResponse.Options.WithContent | undefined):
 
 /** @internal */
 export const redirect = (
-  location: string,
+  location: string | URL,
   options?: ServerResponse.Options.WithContentType | undefined
 ): ServerResponse.HttpServerResponse => {
-  const headers = Headers.unsafeFromRecord({ location })
+  const headers = Headers.unsafeFromRecord({ location: location.toString() })
   return new ServerResponseImpl(
     options?.status ?? 301,
     options?.statusText,