ensure WebSocket's are always closed with an explicit code (#4157)

Effect-TS · Dec 18, 2024 · e66b920 · e66b920
1 parent 9b8e49c
commit e66b920
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/small-pets-sin.md b/.changeset/small-pets-sin.md
@@ -0,0 +1,5 @@
+---
+"@effect/platform": patch
+---
+
+ensure WebSocket's are always closed with an explicit code
diff --git a/packages/platform/src/Socket.ts b/packages/platform/src/Socket.ts
@@ -377,7 +377,7 @@ export const makeWebSocket = (url: string | Effect.Effect<string>, options?: {
       (typeof url === "string" ? Effect.succeed(url) : url).pipe(
         Effect.flatMap((url) => Effect.map(WebSocketConstructor, (f) => f(url, options?.protocols)))
       ),
-      (ws) => Effect.sync(() => ws.close())
+      (ws) => Effect.sync(() => ws.close(1000))
     ),
     options
   )