Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(color) - Adjust page padding for pre-flight checks, trims and throttle setup pages. #3291

Merged
merged 10 commits into from
Mar 13, 2023

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Mar 2, 2023

Fixes #2534

Also made the button size consistent and display better pot/slider name in the center beeps buttons in the pre-flight checks page.

Screen Shot 2023-03-03 at 8 11 55 am

Screen Shot 2023-03-03 at 8 06 38 am

@Eldenroot
Copy link
Contributor

Great, looks much better!

Also would be good to consider a layout for this #3110 , just think about it, because it will require more changes in gui for this page.

@philmoz
Copy link
Collaborator Author

philmoz commented Mar 4, 2023

Add padding to radio setup pages (Sound, Vario, Haptic, Alarm, Backlight and GPS).
Move backlight inactivity timer to its own line and add a label (requires translation).

Screen Shot 2023-03-04 at 12 23 05 pm

@ulfhedlund
Copy link
Contributor

@philmoz: In all the ongoing improvements in the GUI I've noticed that a few of them requires translation.
If possible, it think it would be great if the translators then could be notified. See for example PR #3281 for a list of translators.

ulfhedlund added a commit to ulfhedlund/edgetx that referenced this pull request Mar 4, 2023
@philmoz
Copy link
Collaborator Author

philmoz commented Mar 4, 2023

@philmoz: In all the ongoing improvements in the GUI I've noticed that a few of them requires translation.
If possible, it think it would be great if the translators then could be notified. See for example PR #3281 for a list of translators.

In this case it might be best to wait until the PR is approved in case anyone wants to change my initial choice for the new 'Inactivity timeout' label.

@Eldenroot
Copy link
Contributor

I like it!

radio/src/translations/cz.h Outdated Show resolved Hide resolved
radio/src/translations/cz.h Outdated Show resolved Hide resolved
@pfeerick
Copy link
Member

pfeerick commented Mar 5, 2023

The initial translation is fine by me, but the pause to allow for review is appreciated.

Perhaps for a further tweak to the backlight page, is it worth making it so that when you select 'ON' as the mode that the 'inactivity timeout' and 'off brightness' controls/labels are hidden (or if a page rebuild is feasible, completely hidden) since they are no longer relevant (only valid for the other modes).

@pfeerick
Copy link
Member

pfeerick commented Mar 5, 2023

Can we get some translations for this please 😃

#define TR_BACKLIGHT_TIMER "Inactivity timeout"

image

@philmoz
Copy link
Collaborator Author

philmoz commented Mar 5, 2023

Perhaps for a further tweak to the backlight page, is it worth making it so that when you select 'ON' as the mode that the 'inactivity timeout' and 'off brightness' controls/labels are hidden (or if a page rebuild is feasible, completely hidden) since they are no longer relevant (only valid for the other modes).

The controls were disabled; but hiding them makes more sense - added now.

@pfeerick
Copy link
Member

pfeerick commented Mar 5, 2023

derp... so they were... just there was no visible sign of it (dimmed/greyed out, etc)... so this is perfect...

@robustini
Copy link
Contributor

IT

#define TR_BACKLIGHT_TIMER "Tempo d'inattività"

@HThuren
Copy link
Contributor

HThuren commented Mar 5, 2023

DA
#define TR_BACKLIGHT_TIMER TR2("Inaktivitet", "Ved inaktivitet dæmp efter")

@ulfhedlund
Copy link
Contributor

ulfhedlund commented Mar 5, 2023

SE

#define TR_BACKLIGHT_TIMER "Släck efter inaktivitet"

@TheIsotopes
Copy link
Contributor

DE

#define TR_BACKLIGHT_TIMER "Inaktivitäts Timeout"

@zyren
Copy link
Contributor

zyren commented Mar 5, 2023


CN

#define TR_BACKLIGHT_TIMER "持续时间"



TW

#define TR_BACKLIGHT_TIMER "持續時間"


@ToshihiroMakuuchi
Copy link
Contributor

JP
#define TR_BACKLIGHT_TIMER "持続時間"

radio/src/translations/cz.h Outdated Show resolved Hide resolved
radio/src/translations/cz.h Outdated Show resolved Hide resolved
Phil Mitchell added 9 commits March 12, 2023 16:36
@ajjjjjjjj
Copy link
Contributor

PL
#define TR_BACKLIGHT_TIMER "Czas bezczynności"

@pfeerick pfeerick added color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour labels Mar 13, 2023
@pfeerick pfeerick added this to the 2.9 milestone Mar 13, 2023
@pfeerick pfeerick merged commit 805b848 into EdgeTX:main Mar 13, 2023
@pfeerick pfeerick mentioned this pull request May 23, 2023
9 tasks
@philmoz philmoz deleted the page-padding branch October 9, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Padding is missing on some model setting pages
10 participants