-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(color) - Adjust page padding for pre-flight checks, trims and throttle setup pages. #3291
Conversation
Great, looks much better! Also would be good to consider a layout for this #3110 , just think about it, because it will require more changes in gui for this page. |
In this case it might be best to wait until the PR is approved in case anyone wants to change my initial choice for the new 'Inactivity timeout' label. |
I like it! |
The initial translation is fine by me, but the pause to allow for review is appreciated. Perhaps for a further tweak to the backlight page, is it worth making it so that when you select 'ON' as the mode that the 'inactivity timeout' and 'off brightness' controls/labels are hidden (or if a page rebuild is feasible, completely hidden) since they are no longer relevant (only valid for the other modes). |
Can we get some translations for this please 😃
|
The controls were disabled; but hiding them makes more sense - added now. |
derp... so they were... just there was no visible sign of it (dimmed/greyed out, etc)... so this is perfect... |
IT #define TR_BACKLIGHT_TIMER "Tempo d'inattività" |
DA |
SE #define TR_BACKLIGHT_TIMER "Släck efter inaktivitet" |
DE
|
CN #define TR_BACKLIGHT_TIMER "持续时间" TW #define TR_BACKLIGHT_TIMER "持續時間" |
JP |
Make button size consistent. Fit more buttons per row, Display proper pot and slider names for center beeps.
…ght and GPS). Move backlight inactivity timer to its own line and add a label (requires translation).
PL |
Fixes #2534
Also made the button size consistent and display better pot/slider name in the center beeps buttons in the pre-flight checks page.