Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LVGL Flex Layout: finish screen conversions #2522

Closed
12 tasks done
raphaelcoeffic opened this issue Oct 12, 2022 · 10 comments
Closed
12 tasks done

LVGL Flex Layout: finish screen conversions #2522

raphaelcoeffic opened this issue Oct 12, 2022 · 10 comments
Labels
enhancement ✨ New feature or request
Milestone

Comments

@raphaelcoeffic
Copy link
Member

raphaelcoeffic commented Oct 12, 2022

Description

Release 2.8 is still considered a "transition release", as it is already using LVGL, but some screens are still using the old layouts where every control is set at specific coordinates, and most of the screen is completely recreated on each and every change.

TODOs

The following screens still need to be converted to flex layout:

Per #2522 (comment)

@mha1
Copy link
Contributor

mha1 commented Dec 16, 2022

Hi, can you please check #2818 and point me in the right direction how to fix this? See comments for what I tried and failed miserably.

@philmoz
Copy link
Collaborator

philmoz commented Jan 20, 2023

Global / Special functions - #2992
Logical Switches - #3019

I was going to look at telemetry next if no one else is doing it.

@pfeerick
Copy link
Member

I'm planning to at looking those two PRs and also the Curves one early next week... have just been giving them time for the discussions to finish ;)

@philmoz
Copy link
Collaborator

philmoz commented Jan 21, 2023

Telemetry - #3070

@philmoz
Copy link
Collaborator

philmoz commented Jan 21, 2023

Custom mixer scripts - #3071

@Eldenroot
Copy link
Contributor

Are these all non-converted screens? Any new finding?

@gagarinlg
Copy link
Member

I think that's it

@philmoz
Copy link
Collaborator

philmoz commented Jan 21, 2023

There are still some pages using the FormGridLayout class and direct painting into the bitmap buffer:

@Eldenroot
Copy link
Contributor

Good job, only few issues left from the first post!!!

@pfeerick
Copy link
Member

pfeerick commented Feb 5, 2023

With the merge of the custom script page, this brings to an end the bulk of the LVGL conversion for colorlcd. There is still more work to be done, and improvements that can be made, but this will now mostly flow on from this conversion effort.

@pfeerick pfeerick closed this as completed Feb 5, 2023
@pfeerick pfeerick unpinned this issue Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants