Revised Logical Switches layout

[philmoz]

Summary of changes:

This PR changes the logical switch page with the same style of changes as the special/global functions page in PR 2992 .

• Use LVGL flex layout for the list and edit views
• Fixed height for buttons
• Move switch name into the switch button so the entire row acts as a button
• Group unused switches in rows where possible
• Make button behaviour consistent by always opening pop up menu
• Remember selected button and reselect after edit.

[JimB40]

screen-shots?

[philmoz]

[JimB40]

Okay. Here I will instist to fit list item's data in one line.
Logical Switches are often configured in groups so it's very important to see as much as possible how they are activated.

To my check on whiteboard if we use more tight styling.

• list item height is 38px
• list item background height is 36px
• list item data background height is 32px
  We will be able to fit 5 items.
  And with 3.0 where screen name will move to the topbar even 6 lines

[gagarinlg]

You can look at the gvar LVGL PR, there I fiddled with paddings until I got a density similar to pre LVGL

[JimB40]

Okay here are data fields fixings for all LS functions types with max data length

1. a=x, a<x etc

• V1 - switch
• V2 - numeric value <-100,100> format ##
• AND switch - switch
• Duration - numeric value <0.0,25.0> format ##.#
• Delay - numeric value <0.0,25.0> format ##.#

2. AND ,OR etc

• V1 - switch
• V2 - switch
• AND switch - switch
• Duration - numeric value <0.0,25.0> format ##.#
• Delay - numeric value <0.0,25.0> format ##.#

3. Edge (exception for V2 posotioning as Edge has two V2 values, and Delay that is not applicable)

• V1 - switch
• V2 - numeric value <0.0,175.0> format ##.#
• V2b -mixed value. Either string '<<' or numeric value <0.0,275.0> format ##.#
• AND switch - switch
• Duration - numeric value <0.0,25.0> format ##.#
• Delay - N/A - not displayed.

4. Timer

• V1 - numeric value <0.0,175.0> format ##.#
• V2 - numeric value <0,1750> format ####
• V2b -mixed value. Either string '<<' or numeric value <0.0,275.0> format ##.#
• AND switch - switch
• Duration - numeric value <0.0,25.0> format ##.#
• Delay - numeric value <0.0,25.0> format ##.#

5. Sticky (same as 2 ie AND, OR, XOR)

[philmoz]

My concern with the nested rounded rectangles is that the whole line looks like a button; but does not act like one.

Nothing happens if you tap on the switch name.

[gagarinlg]

The nested stuff is only needed when you eve sub-rows. I would not do this for lists where the entries have no sub-rows.

If this really has to be there, the outer part could get the darker background color

[JimB40]

That's a good point. Names are actually non-touchable (non-focusable labels)
It behaves the same in Inputs & Mixes but difrently in Outputs where list item is grouped together with output name (label)
Let me think a while how can we solve it to unify UI.
Most probably styling change will be enough.

[JimB40]

We may consider this styling change.

So list's item has a frame to group multi-lines list's items but no background that indicates focusable-touchable UI element.

[eshifri]

How about vertical screens (NV14)? Will it be two lines?

[philmoz]

We may consider this styling change.

So list's item has a frame to group multi-lines list's items but no background that indicates focusable-touchable UI element.

With the current 'active switch' color being the same light blue this will make active switches blend into the label section which I think will look a bit odd.

[philmoz]

I've updated the landscape layout to display on a single line. Portrait layout is two lines.
At this stage I've left it as a single button including the switch name (no nested rectangles).

[philmoz]

I have remove all the empty switch buttons and added a single '+' button to match the inputs and mixes pages.

The '+' button will pop up the view to select an empty logical switch unless 'Copy' has been previously selected on another switch. In that case it will show a menu to allow pasting to an empty switch (or creating a new one).

[pfeerick]

Discussion point: What about two buttons at the bottom... one for new, one for paste? i.e. 2 half-width buttons.

Either way, I think we need the same thing done here for the mixes and inputs pages as well.

[philmoz]

Paste is only active if a copy has already been done so you would have a hidden button or one that did nothing.

[philmoz]

I have added a long press handler to quickly access the '+' button functions.

[philmoz]

I have changed the logical switch overview to display the switch function and parameters as an expression (like the special functions PR).

I think this makes the switch operation easier to understand in the overview.

Also added a 's' suffix to time values in the overview and edit pages.

[JimB40]

@

I have changed the logical switch overview to display the switch function and parameters as an expression (like the special functions PR).

I think this makes the switch operation easier to understand in the overview.

I don't think it will work this way .

1. Readiness decreased

2. Have you proofed it with max length data values?
   
   As you can see there is not much fee space, so after adding ON/OFF labels clipping or other layout breaks will occur.

[philmoz]

These are the widest values I can find:

[philmoz]

Maybe it's just me; but I find this:

is easier to understand than this:

[JimB40]

Widest value is negated max telemetry sensor "!WWWW+"

But plaese don't change as there are much more data variances that will cause layout to break.
IE telemetry sensors have unit that can be pretty long and will not fit in any way.
Changig V1 and V2 to ON/OFF is not so simple too plus we have to change docs.

Most important is to see on list properly

• switch/source icon & name
• value

I've tried labels with TINSIZE font but this can decrese UI speed and makes overview cluttered anyway.

We may try to fit in 3.0 header with column names but this will not work for vertical screen anyway.

[Eldenroot]

I've tried labels with TINSIZE font but this can decrese UI speed and makes overview cluttered anyway.

We may try to fit in 3.0 header with column names but this will not work for vertical screen anyway.

Anyway, I love it! Really no way to get this? :)

[philmoz]

@JimB40 Here is another idea to make more room (not sure about the labels as translation could be a problem).

[JimB40]

@philmoz Logical Switches labels are only ones that do not follow XX00 pattern.
CH01,CH02,..
TR01,TR02,..
SF1,SF2,...
GV1,GV2,...
FM1,FM2

Can we adjust Logic Switches labels to LS01, LS02 instead of L01,L02

[pfeerick]

While I do agree, that probably should be material for a different PR. You're talking about a system-wide change (probably also with a Companion UI component also), rather than effectively just the LS LVGL page conversion.

edit: Also need to consider B&W UI, as the same terminology should be used for both colorlcd and B&W.