Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

fix : duplicate tags in search #5534 #7249

Merged
merged 1 commit into from
May 31, 2023

Conversation

shobhitexe
Copy link
Contributor

@shobhitexe shobhitexe commented May 29, 2023

Closes #4676

Changes proposed

have used the MongoDB aggregation framework to convert tags to lowercase using the "$toLower" operator

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

image

Note to reviewers

Hey this i have checked
as in Search.js the tags already converted to lowercase
image

As here the results returning filtered value only
Also have checked and tested by my side every tag is working fine
Need Your reviews Thanks

@github-actions github-actions bot added small Pull request with less than 10 changed lines waiting-for-reviewers labels May 29, 2023
@github-actions
Copy link
Contributor

Reviewpad Report

ℹ️ Messages

  • A maintainer will review your pull request soon!

@ChinmayMhatre
Copy link
Member

Could you add screenshot of the search page tags from your local

@shobhitexe
Copy link
Contributor Author

Could you add screenshot of the search page tags from your local

Sure Here you go

2023-05-29.15-28-30.-.Trim.mp4

@SaraJaoude SaraJaoude added the issue linked Pull Request has issue linked label May 30, 2023
@eddiejaoude
Copy link
Member

Thank you 👍 and great for checking the search itself 🚀

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@eddiejaoude eddiejaoude merged commit 9663f96 into EddieHubCommunity:main May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue linked Pull Request has issue linked small Pull request with less than 10 changed lines waiting-for-reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag duplication when case is different on search page
4 participants