Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Tag duplication when case is different on search page #4676

Closed
amandamartin-dev opened this issue Feb 10, 2023 · 23 comments · Fixed by #7249
Closed

Tag duplication when case is different on search page #4676

amandamartin-dev opened this issue Feb 10, 2023 · 23 comments · Fixed by #7249
Assignees
@shobhitexe
Labels
💻 aspect: code undefined 🛠 goal: fix undefined 🔢 points: 3 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)

Comments

@amandamartin-dev
Copy link
Contributor

Description

On the search page there are 3 different tags for JS due to different use of case. Recommend standardizing all tags (not just JS) into the same case to prevent duplication

search bug

Screenshots

No response

Additional information

No response
@amandamartin-dev amandamartin-dev added 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) 🛠 goal: fix undefined labels Feb 10, 2023
@github-actions
Copy link
Contributor

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@GauravBurande
Copy link
Contributor

I think there was already the same issue.

@amandamartin-dev
Copy link
Contributor Author

I think there was already the same issue.

I thought so too but when I searched I did not find one. If you find it, please link it here and then we can close this one.

@ManishBisht777
Copy link
Contributor

I think there was already the same issue.

I thought so too but when I searched I did not find one. If you find it, please link it here and then we can close this one.

Here #3604

@ManishBisht777
Copy link
Contributor

ManishBisht777 commented Feb 11, 2023 •
edited
Loading

but #3604 is closed

@amandamartin-dev
Copy link
Contributor Author

but #3604 is closed

Ah Interesting! Perhaps something was changed to make the issue resurface as that ticket was "closed as completed" but it's definitely still happening. I will leave this open for assessment as it seems to be needed still

@eddiejaoude
Copy link
Member

They all get selected but yes it would be a better UX if they were only displayed once 👍

Screenshot 2023-02-12 at 07 25 44

@eddiejaoude eddiejaoude added 💻 aspect: code undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) 🔢 points: 3 undefined and removed 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Feb 12, 2023
@joe-shajan
Copy link
Contributor

Correct @eddiejaoude It will be a lot better. I would like to fix this issue. Can you assign this to me?

@eddiejaoude
Copy link
Member

Sure, assigned @joeshajan

@gptkrsh
Copy link
Contributor

gptkrsh commented Feb 12, 2023

I would suggest we just capitalize/serialize these when the API gives the user profile. That will allow lapps to work with it as well

@Aadarsh805
Copy link
Member

They all get selected but yes it would be a better UX if they were only displayed once +1

Screenshot 2023-02-12 at 07 25 44

I noticed one more thing here, now that we have implemented the functionality where it highlights all the tags ignoring case sensitivity
but there's still this issue, that we can still on some other same tag (but differently spelled) it gets in the search field

screen-capture.1.mp4

I think this will be fixed, once we do the case checking beforehand and then there will be no same tags
that's why didn't raise separate issue for it

@joe-shajan
Copy link
Contributor

Yeah got it will keep that in mind

@joe-shajan
Copy link
Contributor

Can someone please explain how can I get some data in my local database?
Is there any way to data from the production database for testing?

@FrozenHearth FrozenHearth mentioned this issue Feb 15, 2023
Closed
@amandamartin-dev amandamartin-dev mentioned this issue Feb 26, 2023
Closed
@joe-shajan joe-shajan mentioned this issue Mar 18, 2023
Closed
6 tasks
@swagataroy30 swagataroy30 mentioned this issue Mar 27, 2023
Closed
@Akhilbisht798
Copy link
Contributor

Akhilbisht798 commented Mar 30, 2023 •
edited
Loading

Hey @joeshajan are you still working on this issue? if not i would love to contribute to this.

@joe-shajan
Copy link
Contributor

Hey @joeshajan are you still working on this issue? if not i would love to contribute to this.

I have already raised a pr

@eddiejaoude
Copy link
Member

Hey @joeshajan are you still working on this issue? if not i would love to contribute to this.

@Akhilbisht798 please see the issue timeline above your comment, it shows the linked PRs as well as the conversation

@Akhilbisht798
Copy link
Contributor

Oh my bad, i misunderstood it. I am really sorry about it.

@swagataroy30 swagataroy30 mentioned this issue Apr 5, 2023
Closed
@amandamartin-dev
Copy link
Contributor Author

amandamartin-dev commented Apr 26, 2023 •
edited
Loading

Hello @joe-shajan I see you mentioned raising a PR, but this issue still exists on production. Are you working on this still or can it be reassigned? If a PR is open, can you link it - I am not seeing it

EDIT - nvm, found the PR just after I commented. Apologies

@amandamartin-dev amandamartin-dev mentioned this issue Apr 26, 2023
Closed
This was referenced May 5, 2023
Closed
Closed
@shobhitexe
Copy link
Contributor

Hey is anyone working on it
was waiting for linkfree to migrated to atlas as eddie said but i see the problem is still there
#6612 (comment)
am from the above issue
i see its assigned to someone but he is not working on it
i would like to take this if no ones working on it
Thanks

@SaraJaoude
Copy link
Member

Hey is anyone working on it
was waiting for linkfree to migrated to atlas as eddie said but i see the problem is still there
#6612 (comment)
am from the above issue
i see its assigned to someone but he is not working on it
i would like to take this if no ones working on it
Thanks

@shobhitexe as you can see from #5534 the author is working on the Issue and the last activity was yesterday. Whilst we appreciate your enthusiasm to move things along, please be more mindful of other contributors' time, not adding extra pressure and not creating additional notifications for everyone involved.

@SaraJaoude
Copy link
Member

Due to lack of activity I have unassigned this issue.

@shobhitexe given your comments on here would you like me to assign this issue to you?

@shobhitexe
Copy link
Contributor

Due to lack of activity I have unassigned this issue.

@shobhitexe given your comments on here would you like me to assign this issue to you?

Sure i would love to work on this

@SaraJaoude
Copy link
Member

Due to lack of activity I have unassigned this issue.
@shobhitexe given your comments on here would you like me to assign this issue to you?

Sure i would love to work on this

@shobhitexe I have assigned this to you

@shobhitexe shobhitexe mentioned this issue May 29, 2023
Merged
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shobhitexe shobhitexe

Labels
💻 aspect: code undefined 🛠 goal: fix undefined 🔢 points: 3 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)
Projects
None yet
Milestone
No milestone
10 participants
@eddiejaoude @shobhitexe @joe-shajan @SaraJaoude @ManishBisht777 @gptkrsh @Akhilbisht798 @Aadarsh805 @amandamartin-dev @GauravBurande