Event filters #2687
Event filters #2687
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
It's great having you contribute to this project
Welcome to the community 🤓If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.
github-actions
bot
added
large
* adding useState at required page * removing unused index variable Co-authored-by: Abhi Jain <[email protected]> Co-authored-by: Eddie Jaoude <[email protected]>
There was a problem hiding this comment.
LGTM but would suggest one more reviewer that works in the project more often than I do
One edit you can consider: Defining CFP on the legend
Thoughts about possible follow up issues needed due to this update:
Is the mobile view too stacked with the legend now that there are 4 items? Possible need for a dropdown or some other type of filter on mobile?
This will require an update to documentation on the events directions likely as well
|
Thanks @amandamartin-dev , comments inline below ...
Good point 👍
Yep, this is true 👍 hopefully it can come in another PR soon.
I think I have covered that, but if not let me know |
OMG I missed that 🤦♂️ thank you Dan 🔥 I will do that now |
Fixes Issue
fixes #2528
fixes #2677