I have added filter options to see events virtual/in person #2605
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
It's great having you contribute to this project
Welcome to the community 🤓If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.
| Welcome @abhijain2003! Thank you so much for your first pull request! |
components/user/UserEvents.js
Outdated
| ))} | ||
| ) | ||
| ) | ||
| })} |
There was a problem hiding this comment.
These changes seem to be the same but with a console log?
|
can you give me one more chance I'll resolve all conversation |
of course, we are here to help, any questions let us know 👍 |
|
can I add a small button to take back to previous stage and show all events |
|
I have refactor the code didn't made any changes in package-lock previously so didn't toched it now as well Can I commit it or would you like to give me more advices |
|
Great! Always commit otherwise we can't see the changes - GitHub will append them to this PR for review |
Hey @abhijain2003 , I think what Eddie means. By the |
|
ok |
|
I think we should add a border to the selected event type. What do you think @abhijain2003 , @eddiejaoude ? |
Hey , I think eddie also had suggested to remove the package-lock.json from the pr. |
I added a kind of scale property on hover on selected button |
I think this can come in another PR |
|
so will you merge it now |
@abhijain2003 please review remaining inline comments |
|
ok eddie |
|
eddie as you told me I have removed package-lock file and made a new commit hope there are no further checks are remaining |
Please do not remove this file, it is important, I asked to remove your changes to the file. You can use Also please address the remaining 2 inline comments that are not in a resolved state yet (these are the ones that are still expanded on this page (the others are collapsed as they are resolved) |
|
hey Eddie, I think I messed up the contribution, but I resolved all conversations now, Thanks for Helping |
|
@abhijain2003 you marked this as resolved without a comment or changing the lines of code it is referring to, this makes it difficult to review. Do you need some help with this? I have marked it back to unresolved.
|
|
not at all eddie this button was by mistaken pressed I am sorry for that, and I made changes in code, removed unused imports and this issue is also resolved and even the changes you can see was becuase initially I write my code in wrong file, then I changed before my first pr that's why github is showing those changes |
can you remove any change you don't want. Please see my inline comment https://github.com/EddieHubCommunity/LinkFree/pull/2605/files#r1060438032 |
|
done eddie , i commited to my branch all changes hope now it is resolved |
pages/events.js
Outdated
| @@ -20,6 +21,8 @@ export async function getServerSideProps(context) { | |||
| } | |||
|
|
|||
| export default function Events({ events }) { | |||
|
|
|||
| const [eventType, seteventType] = useState(''); | |||
There was a problem hiding this comment.
useState will need an import
There was a problem hiding this comment.
thank eddie, for letting me know I just added it
pages/events.js
Outdated
| <EventCard event={event} username={event.username} key={index} /> | ||
| ))} | ||
| {events | ||
| .filter((event, index) => { |
There was a problem hiding this comment.
I don't think index is used here?
There was a problem hiding this comment.
yes you are right, I have removed it
github-actions
bot
added
small
|
Thank you 👍 I will resolve conflicts |
|
thanks to you, you really helped me in my initial stage of open source looking forward to contribute more |
|
Thank you for your hard work @abhijain2003 💪 |
* I have added filter options to see events virtual/in person * resolving issues renamed descriptive variables and removed unused variables * Update events.js * removing package-lock file * removed unused import * removing unused changes * feat: events filter (#2605) * adding useState at required page * removing unused index variable Co-authored-by: Abhi Jain <[email protected]> Co-authored-by: Eddie Jaoude <[email protected]> * fix: remove unrequired changes * feat: filter events by cfp #2677 * fix: user events list * fix: cfp filter for events Co-authored-by: abhi jain <[email protected]> Co-authored-by: Abhi jain <[email protected]>
Fixes Issue
#2528
Changes proposed
-> initialize state variable in events.js file with toggle values "virtual"/"person"
-> passing setState method in eventKey.js file as a props so I can toggle values on button clicks
-> implementing filter method before map in events.js file based on value of state variable
-> added a scale-105 class on hover in EventKey.js file
Screenshots
Events.the.community.members.are.going.to.-.Google.Chrome.2023-01-03.10-05-34.mp4