-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extension]
already published, but currently isn't active and therefore not visible
#2062
Comments
Notably, this is happening for the following extensions:
@kineticsquid I think we should mark this as a high-priority issue, because it's disrupting the use of the registry 🙏 |
I just tried publishing a smaller extension and the same issue occured. It looks pretty widespread. |
@filiptronicek Agree with the priority and agree that something funny is going on. Here's another data point: #2050. In this case, it looks like the extension got into a bad state with a publication that was not activated. Then, no matter what was published, it was not activated. I tried and failed. I was able to publish to the same code to my namespace with no problem. When I removed the deactivated versions, I was able to publish. |
Because of this issue, our biggest extension on the public instance of the registry, I am not sure how exactly we can proceed here considering the scale. @kineticsquid could you for these cases try to unpublish the extensions listed above so that I can try re-publishing them? It's no long-term solution, but I'm curious to see how exactly it will come back |
@filiptronicek I tried a few experiments last night. The extensions I then added myself as a contributor to these two name spaces in production and attempted to publish the same I removed If these works, I'd like to go back and remove the other versions I published and have you re-publish those. |
Thanks a bunch for your effort here, @kineticsquid 🙏. I'll take a look at Python and Jupyter now - Jupyter indeed has stoppped publishing GitHub Releases, so they only release to the Microsoft Marketplace now. I'll get back to you and we'll see about republishing the extensions you fixed. |
@kineticsquid Python and Jupyter published ✅ |
Woo Hoo! |
Hey all, Any help will be greatly appreciated! 😋 UPDATE: Thank you! |
I published v3.72.0 of the Dart extension earlier today, and then 3.72.1 with a fix around 30 mins ago. The initial release showed up, but I'm seeing this issue after publishing the fix. I'm not sure whether it just takes a while to go through or if it's broken. The fix is quite important so if it doesn't show up in the next 20-30 mins I'm just going to bump the version number and try again, but I thought it was worth recording here in case you can gain any insight from logs/whatever. Edit: 3.72.1 just showed up on the website (although not yet |
@amvanbaren Might be able to add more here. The file processing is done asynchronously. As a consequence of this, an extension tile will show deactivated until the file processing is complete (and there are no errors). @zFernand0 Any idea how long after publishing it took your extension to show up as active? @DanTup Similar question, how long after your extension showed as active it take for |
@kineticsquid it showed up in metadata very shortly after it showed up on the website (right after I posted above). So it was around 1hr for the extension to show up both on the website + metadata, there was just a very slight delay between them (which I suspect was just some caching). |
Any estimated timeline for fixing this? @kineticsquid |
@kineticsquid could you please look into removing the latest of https://open-vsx.org/extension/vscjava/vscode-java-test? It should be The latest downloadable version, |
unpublish both |
Removed |
@filiptronicek @amvanbaren Do we need to keep this one open? |
@kineticsquid let's close and re-open if needed 🙏 |
I investigated this issue on my end and I have some interesting findings that I would like to share. While debugging locally, I found out that this is a concurrency issue. When a new extension is published, the web ui will send a request to the server to publish the extension [1], then immediately send another request to re-fetch the list of extensions published by the user [2]. The server will run these 2 requests in parallel. The problem occurs because we are trying to write to the database while performing a The problem is caused exactly by this line: https://github.com/eclipse/openvsx/blob/84d01402f007233c8a1e5b28587e4f4784c7d3fd/server/src/main/java/org/eclipse/openvsx/util/VersionService.java#L38
|
This still seems to be happening.. I noticed the last two Dart-Code releases (one around a month ago, and one earlier today) are not showing. Both of them give this same error if I try to re-publish them:
https://open-vsx.org/extension/Dart-Code/dart-code It's possible the latest one just hadn't gotten through the caches yet, but it's been a month since 3.80.0 was published. Is it possible someone can either make them active or delete them so I can re-publish them? |
@DanTup I just looked and I see |
@kineticsquid that would be great, thanks! |
@DanTup |
@kineticsquid thanks! I re-published that one and it's showing up now :) |
@kineticsquid UPDATE: I had several to update this last weekend, all of which were affected: user, ext, new, active |
@sjsepan3 I can see you have other extensions that seem to be publishing successfully. Sometimes, though not always, extensions fail to activate because of an error in the package contents (admittedly we don't do a good job of reporting on this). I'd investigate but the repos above appear to be private. |
The GitLab links were a long-standing error that was among the things I was updating with this latest round of publishing. https://gitlab.com/sjsepan/sjsepan-nevadaish Steve |
@sjsepan3 I cloned your repo and attempted to build the extension. I get this error message:
I then changed this line in your
to:
Packaged it again and published and it activated. |
-the path ought to evaluate to the same thing, but I can simplify it (Done, w/ Nevadaish) |
@kineticsquid Update: I cleared the page cache and refreshed the page, but still the same |
@sjsepan3 Using my admin super powers I removed v Are you saying that some of these extension versions that were active because deactivated? Or that you published new versions, without changing anything and the newer versions didn't activate? |
I will have to re-investigate 'vsce package', although the "root" where I run it will likely be the pkg folder, because that is the content that goes into a .vsix.
The latter, except I did change the .json file in several and the .vsixmanifest file in all of them. |
@kineticsquid You can consider this closed. I will go through my other projects later... I have opened up the generated .vsix (it is jsut a .zip with a folder structure and content like my extension folder) and I'm looking for differences -- because I want to know why my bash-generated packages worked for so long and suddenly stopped working here. So far the only differences (according to Meld) are in what goes into the content types and the manifest. The former omitted the xml mime ( |
@kineticsquid
So far it is looking like it is not the content, but the archive ( |
Hi @sjsepan3,
Please use |
Well that's a detail that we didn't see before. I don't like magic -- its just a zip file. The layout I used inside is the same, and the content is the same. Is there some sort of hidden signing going on? |
You can do some interesting things with a ZIP archive's extra field: https://gitlab.eclipse.org/security/vulnerability-reports/-/issues/213 |
I see, Thank You. Good enough reason to alter my workflow slightly. VSCE it is.
BTW, I don't see a package option in the OVSX tool help. I've started using vsce, but how do I do that in the ovsx tool? |
If you also publish to the MS marketplace, then just package (and publish) the extension using |
OK, nothing for me to do differently with that, then. Thank You @amvanbaren ! |
@sjsepan3 No worries, glad we got to the bottom of this. |
For many extensions, something goes wrong during the publishing making the new versions not "active" on the registry.
This happens for many extensions and is really inconvenient, because there is no apparent action to be taken on the side of the extension author. The occurrence of this issue seems random and I don't see a pattern with what goes and what doesn't.
From the logs:
Possibly related to #1444
The text was updated successfully, but these errors were encountered: