Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publisher's extensions list: current versions; details pages: old version, including actual link #2050

Closed
sjsepan3 opened this issue Aug 12, 2023 · 21 comments

Comments

@sjsepan3
Copy link

sjsepan3 commented Aug 12, 2023

https://open-vsx.org/user-settings/extensions

  • 7 out of 9 entries in the publisher's (my) listing show current versions, while the details page show an older version and links to the older version
  • those same 7 out of 9 entries do not have icons visible, even though they were visible on earlier publishing attempts

name, pub. list v, details v,. link
sjsepan-humanelike, 0.0.6, 0.0.5, https://open-vsx.org/extension/sjsepan/sjsepan-humanelike
sjsepan-blueish, 0.0.3 , 0.0.2, https://open-vsx.org/extension/sjsepan/sjsepan-blueish
sjsepan-greenish, 0.0.3 , 0.0.2, https://open-vsx.org/extension/sjsepan/sjsepan-greenish
sjsepan-reddish, 0.0.3 , 0.0.2, https://open-vsx.org/extension/sjsepan/sjsepan-reddish
vscode-smallvisualbasi,c 0.0.4 , 0.0.2, https://open-vsx.org/extension/sjsepan/vscode-smallvisualbasic
vscode-xsharp , 0.0.4, 0.0.2, https://open-vsx.org/extension/sjsepan/vscode-xsharp
vscode-jsharp, 0.0.4, 0.0.2, https://open-vsx.org/extension/sjsepan/vscode-jsharp

-I have cleared my cache, but the condition remains

@kineticsquid
Copy link
Contributor

@sjsepan3 For the 7 entries in question, on your /user-settings/extensions page, do any of them show as 'Deactivated'? Like this:
image

@sjsepan3
Copy link
Author

Screenshot from 2023-08-14 21-08-34

Mu listing shows me only the most recent -- if there are older versions, they do not seem to be visible to me in the view illustrated.

@sjsepan3
Copy link
Author

Screenshot from 2023-08-14 21-11-51

In this example of one of the detail pages, which is what is directly linked from the list view, I do not notice any indication that this (older) version is deactivated.

@kineticsquid
Copy link
Contributor

@sjsepan3 Thanks, that answered my question. A deactivated extension version will show up on the /user-settings/extensions page and I don't see that on the screen cap above.

Looking specifically at XSharp, you have published 2 versions, 0.0.2 and 0.0.4, you can see 0.0.4 from your settings but clicking on that tile from your settings page takes you to the extension details page where you see only 0.0.2. Is that correct?

Just out of curiosity, what changes did you make from 0.0.2 to 0.0.4, any changes to package.json?

Do you get any error messages when you publish with npx osvx publish ... --debug?

@sjsepan3
Copy link
Author

sjsepan3 commented Aug 16, 2023

Yes, that is correct; the list shows 0.0.4 and the detail shows 0.0.2.

I will have to check my Git to see what the changes were, but its likely there were some in package.json. I will try to follow up with that info.

I cannot test the npx stuff (yet) because the machine I used is not available. ( I built a new system this week, and moved my home drive to it, but not all of the tools are installed on the new machine, yet. The older machine is re-purposed.

UPDATE1: Just checking the changelog, I see that what changed in the package.json, besides the version, would be the repository url (0.0.3).

UPDATE2: I've reinstalled node, vsce and osvx. I ran my best guess at the right command ("npx osvx publish sjsepan.vscode-xsharp-0.0.4.vsix --debug") but I get errors.

npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/osvx - Not found
npm ERR! 404 
npm ERR! 404  'osvx@*' is not in this registry.
npm ERR! 404 
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/sjsepan/.npm/_logs/2023-08-16T11_10_04_750Z-debug-0.log

Then I remembered that I published by dragging onto the publish page, not by using the terminal.

@kineticsquid
Copy link
Contributor

To get the debug information you need to use the command line. And I make this mistake all the time. It's ovsx not osvx. You can confirm your installed node stuff with npm list.

@sjsepan3
Copy link
Author

the publish w/ debug output looks like

$npx ovsx publish sjsepan.vscode-xsharp-0.0.4.vsix --debug --pat  [redacted]
Error: Extension sjsepan.vscode-xsharp 0.0.4 is already published, but currently isn't active and therefore not visible.
    at IncomingMessage.<anonymous> (/usr/lib/node_modules/ovsx/lib/registry.js:185:40)
    at IncomingMessage.emit (node:events:525:35)
    at endReadableNT (node:internal/streams/readable:1359:12)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)

@sjsepan3
Copy link
Author

I'm not sure what the context of 'npm list' should be. When run from the publish location, I get
/home/sjsepan/Projects/VSCode/sjsepan.vscode-xsharp └── (empty)

@kineticsquid
Copy link
Contributor

@sjsepan3 The publishing error above is because that version is already published, but not activated because of some error. This is more or less what I expected. But it's odd that it's not showing up that way on your settings page.

Rev the version number on package.json to, say, 0.0.5 and try again to publish with the --debug option.

If you're able to give me access to this repo, I'll clone it and experiment a bit to see what's going on.

@sjsepan3
Copy link
Author

sjsepan3 commented Aug 17, 2023

If you're able to give me access to this repo, I'll clone it and experiment a bit to see what's going on.

@kineticsquid
Let me know if you are unable to clone from the repo, which is at :
https://gitlab.com/sjsepan/sjsepan.vscode-xsharp

@sjsepan3
Copy link
Author

sjsepan3 commented Aug 17, 2023

Rev the version number on package.json to, say, 0.0.5 and try again to publish with the --debug option.

@kineticsquid
OK, did that...(I have not pushed this to the repo that you may be cloning)
0.0.5.vsix --debug --pat [redacted]
🚀 Published sjsepan.vscode-xsharp v0.0.5
Will check the listings and see the outcome...

UPDATE1: OK, I looked at the extensions list which shows 0.0.5, and went to the details page, which shows/offers 0.0.2. So, same result, apparently.

@kineticsquid
Copy link
Contributor

Thanks, I can see the repo. I'll poke at this a bit.

@kineticsquid
Copy link
Contributor

@sjsepan3 I cloned your repo and made one change: "publisher": "kineticsquid",. Package and published. Worked for me: https://open-vsx.org/extension/kineticsquid/vscode-xsharp. I suspect this is having something to do with your changes to package.json. Can you show me what they were?

@sjsepan3
Copy link
Author

sjsepan3 commented Aug 17, 2023

@kineticsquid
Early on, after I cloned the original extension, and before I published here (I think), the original version# was higher (1.0.3) and the published id I was using for extensions was a guid. While learning how to publish, I observed that the guid was not going to be very user-friendly, and I really had no reason to carry over the version like I had carried-over the license. I also added some more metadata.
Screenshot from 2023-08-17 15-27-25

Between v 0.0.2 and 0.0.3 I fixed the repo url from github to gitlab (it was never on github).

Other than version numbers, the package has not changed much since.

@kineticsquid
Copy link
Contributor

@sjsepan3 OK, I made a bit of progress. I added myself to your namespace as a contributor (one of my super powers). Then I attempted to publish to your namespace your most recent version, the one I successfully published to my namespace. That failed. I noticed that there were several versions published in your namespace since 0.0.2 that were not active. So I deleted all the deactivated versions, leaving only 0.0.2. I then attempted again to publish your most recent code as 0.0.4. That worked. You can see that here: https://open-vsx.org/extension/sjsepan/vscode-xsharp. I'm wondering if there was an error in one of the deactivated versions that somehow put things in a bad state. To be sure, I tried again with 0.0.5. That worked.

Can you try now to publish another version of sjsepan/vscode-xsharp.

@sjsepan3
Copy link
Author

sjsepan3 commented Aug 21, 2023

@kineticsquid
I will try that, but it does illustrate something I've been trying to get a handle on: why is it I cannot see those older versions in the list, only the detail, and why is the list showing something (0.0.4) that may or not be there. (At this point, I am still not clear which is the case, because I now know what I suspected: there are hidden items lingering around that I can't see.)
Also, should I be trying to unpublish old versions explicitly then, when this happens?

Steve

@sjsepan3
Copy link
Author

sjsepan3 commented Aug 21, 2023

@kineticsquid
OK, that appeared to have worked -- 0.0.6 is published in the list AND detail; the icon appears in the list item.

So, for the others...rather than bumping the version on all of them (which will require me pushing Git updates to two online repos (GitLab and Codeberg), and publishing to both OVSX and the VSCE / MS marketplace) ... can I just attempt to unpublish the older version that are causing the 'log-jam', as it were?

UPDATE1: nope, those attempts in my command history were fails; there is no unpublish or remove in ovsx. I guess I'll rely on you to remove the old ones (including the last version attempt if it is stuck in there, so, re: the previous paragraph, I don't have to bump versions on all of them. If that is possible.)

UPDATE2: I just saw the mention and the other issue, so I will wait and see what is decided for the overall topic. Thanks for all the work so far uncovering the behavior.

@kineticsquid
Copy link
Contributor

@sjsepan3 Unfortunately you can't unpublish, that is something I need to do. For each of the remaining extensions, here's what I did:

  • sjsepan-humanelike, kept 0.0.5, removed 0.0.6
  • sjsepan-blueish, kept 0.0.2, removed 0.0.3
  • sjsepan-greenish, kept 0.0.2, removed 0.0.3
  • sjsepan-reddish, kept 0.0.2, removed 0.0.3
  • vscode-smallvisualbasi, kept 0.0.2, removed 0.0.3 and 0.0.4
  • vscode-jsharp, kept 0.0.2, removed 0.0.3 and 0.0.4

Would you try now to re-publish.

@sjsepan3
Copy link
Author

sjsepan3 commented Aug 22, 2023

Would you try now to re-publish.

@kineticsquid
Understood; will update you with the results...

npx ovsx publish sjsepan-humanelike-0.0.6.vsix --debug --pat xxx
🚀  Published sjsepan.sjsepan-humanelike v0.0.6

List is 0.0.6
Detail is 0.0.6 OK

npx ovsx publish sjsepan-blueish-0.0.3.vsix --debug --pat xxx
🚀  Published sjsepan.sjsepan-blueish v0.0.3

List is 0.0.3
Detail is 0.0.3 OK

npx ovsx publish sjsepan-greenish-0.0.3.vsix --debug --pat xxx
🚀  Published sjsepan.sjsepan-greenish v0.0.3

List is 0.0.3
Detail is 0.0.3 OK

npx ovsx publish sjsepan-reddish-0.0.3.vsix --debug --pat xxx
🚀  Published sjsepan.sjsepan-reddish v0.0.3

List is 0.0.3
Detail is 0.0.3 OK

npx ovsx publish sjsepan.vscode-smallvisualbasic-0.0.4.vsix --debug --pat xxx
🚀  Published sjsepan.vscode-smallvisualbasic v0.0.4

List is 0.0.4 or 0.0.2 ...randomly changing with refreshes
Detail is 0.0.4 OK

npx ovsx publish sjsepan.vscode-jsharp-0.0.4.vsix --debug --pat xxx
🚀  Published sjsepan.vscode-jsharp v0.0.4

List is 0.0.4
Detail is 0.0.4

Strange caching dynamics at play, particularly in the list view; I'll see some list items not updated, then after several refreshes they are (OK), then later after uploading another extension, one of the earlier ones comes up looking like the old version again.
I closed and reopened the list page, and one item that was current, then old, was current again, (reddish) and one that was current (smallvisualbasic) was old (the detail is current). Not sure how to interpret that, except that the detail views all appear to be current now.

UPDATE1: This morning all looks well. The caching mentioned above is something to keep an eye on, but I think this issue can be closed. Thank You for all the work.

@kineticsquid
Copy link
Contributor

Tracking this general issue in #2062

@kineticsquid
Copy link
Contributor

@sjsepan3 I agree there appears to be some funniness with the caching. Let's treat that separately. Thanks for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants