Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created the Korean translation for CONTRIBUTING.md document #6060

Merged
merged 4 commits into from
Oct 9, 2021

Conversation

andylang8445
Copy link
Contributor

What does this PR do?

Added the Korean translation of the document

For resources

Description

Why is this valuable (or not)?

How do we know it's really free?

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • [√ ] Read our contributing guidelines
  • [ √] Search for duplicates.
  • [ √] Include author(s) and platform where appropriate.
  • [ √] Put lists in alphabetical order, correct spacing.
  • [ √] Add needed indications (PDF, access notes, under construction)

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@eshellman
Copy link
Collaborator

language code for korean is ko, not kr

@eshellman eshellman added the waiting for changes PR has been reviewed and changes/suggestions requested label Oct 8, 2021
@andylang8445
Copy link
Contributor Author

I have updated the title of the document

@davorpa
Copy link
Member

davorpa commented Oct 8, 2021

@eshellman I'm confused. Korean is already here #5837. And there are too much differences between both

Needs disambiguation (https://www.localeplanet.com/icu/iso639.html#ko):

  • North Korea (ko_KP)
  • South Korea (ko_KR)

@davorpa davorpa added the question Needs clarification by involved users / reviewers label Oct 9, 2021
@andylang8445
Copy link
Contributor Author

Since this is the translation of the document, numerous different way of translation exists. Also South Korean and North Korean "Korean" language has quite a big difference between. To be clear, this specific doc is using the South Korean (ko_KR) language.

@eshellman
Copy link
Collaborator

Please work with @filoscoder to see if improvements can be made. Two heads are better than one, and 나는 한국어를 읽거나 쓰지 않는다
Thanks, and welcome to free-programming-books!

@eshellman eshellman merged commit d3e6ee5 into EbookFoundation:master Oct 9, 2021
@davorpa davorpa mentioned this pull request Oct 9, 2021
39 tasks
@filoscoder filoscoder mentioned this pull request Nov 3, 2021
8 tasks
@davorpa davorpa added 🗣️ locale:ko Resources addressing "Korean / 한국어 [韓國語]" language New Feature New feature / enhancement / translation... 🗣️ translations Issues or PRs addresing translations labels Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature New feature / enhancement / translation... question Needs clarification by involved users / reviewers 🗣️ locale:ko Resources addressing "Korean / 한국어 [韓國語]" language 🗣️ translations Issues or PRs addresing translations waiting for changes PR has been reviewed and changes/suggestions requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants