Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added links to korean docs #5837

Merged
merged 16 commits into from
Nov 3, 2021
Merged

Added links to korean docs #5837

merged 16 commits into from
Nov 3, 2021

Conversation

filoscoder
Copy link
Contributor

@filoscoder filoscoder commented Oct 3, 2021 •
edited
Loading

What does this PR do?

Implements Korean translation of certain docs:

  • CONTRIBUTING Korean translation
  • Added links to Korean docs
  • Added links to korean docs

Checklist:

  • Read our contributing guidelines
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction)

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@eshellman
Copy link
Collaborator

I would separate the translation and the links to it into two separate PRs. The links generate the conflicts, and we can do a cleanup PR after things have settled a bit.

@eshellman eshellman added the conflicts Conflict(s) need to be resolved label Oct 4, 2021
@davorpa davorpa added the New Feature New feature / enhancement / translation... label Oct 5, 2021
@davorpa davorpa mentioned this pull request Oct 5, 2021
Merged
5 tasks
@davorpa
Copy link
Member

davorpa commented Oct 5, 2021

HOWTO also here #5908

@davorpa davorpa added the duplicate Contributed resource, issue, pull request... already exists label Oct 5, 2021
@filoscoder
Copy link
Contributor Author

filoscoder commented Oct 5, 2021 •
edited
Loading

Thanks for the guide, I just rebased the source including duplicate works on Korean documentation. Also updated my PR description.
I think the PR is clean and ready to Merge!

Please take a quick check @eshellman @davorpa

@davorpa davorpa self-requested a review October 5, 2021 11:26
davorpa
davorpa requested changes Oct 5, 2021
View reviewed changes
Copy link
Member

@davorpa davorpa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ It seems there are some markdown syntax changes in english files, even in langs paragraph.

Maybe disable or adapt editor formatter in this project.

CONTRIBUTING-kr.md Outdated Show resolved Hide resolved
davorpa
davorpa reviewed Oct 5, 2021
View reviewed changes
HOWTO.md Outdated Show resolved Hide resolved
davorpa
davorpa reviewed Oct 5, 2021
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@filoscoder filoscoder requested a review from davorpa October 5, 2021 12:43
davorpa
davorpa requested changes Oct 5, 2021
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING-kr.md Outdated Show resolved Hide resolved
CONTRIBUTING-kr.md Outdated Show resolved Hide resolved
CONTRIBUTING-kr.md Outdated Show resolved Hide resolved
CONTRIBUTING-kr.md Outdated Show resolved Hide resolved
@filoscoder filoscoder requested a review from davorpa October 8, 2021 14:52
davorpa
davorpa reviewed Oct 8, 2021
View reviewed changes
CONTRIBUTING-kr.md Outdated Show resolved Hide resolved
@filoscoder filoscoder requested a review from davorpa October 8, 2021 19:10
davorpa added a commit to davorpa/free-programming-books that referenced this pull request Oct 8, 2021
@davorpa
chore(docs): fix all annoying markdown problems
8cae0f3 
Finish review EbookFoundation#5837
davorpa added a commit to davorpa/free-programming-books that referenced this pull request Oct 8, 2021
@davorpa
chore(docs): fix all annoying markdown problems
ebd8d66 
Finish review EbookFoundation#5837
davorpa
davorpa reviewed Oct 8, 2021
View reviewed changes
Copy link
Member

@davorpa davorpa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply the patch (filoscoder/free-programming-books#1) submitted to your repo as it's, thanks

@davorpa davorpa added waiting for changes PR has been reviewed and changes/suggestions requested and removed duplicate Contributed resource, issue, pull request... already exists labels Oct 8, 2021
@davorpa davorpa mentioned this pull request Oct 8, 2021
Merged
@eshellman
Copy link
Collaborator

language code for Korean is ko not kr

@eshellman eshellman removed the conflicts Conflict(s) need to be resolved label Oct 9, 2021
@davorpa davorpa mentioned this pull request Oct 9, 2021
Closed
39 tasks
@filoscoder
Copy link
Contributor Author

filoscoder commented Oct 10, 2021 •
edited
Loading

language code for Korean is ko not kr

Should I rename the files?
kr => ko_KR?

@filoscoder filoscoder changed the title Implementation of DOCS translations in Korean Implementation of CONTRIBUTING translation in Korean Oct 10, 2021
@eshellman
Copy link
Collaborator

language code for Korean is ko not kr

Should I rename the files? kr => ko_KR?

just ko

@davorpa davorpa mentioned this pull request Oct 11, 2021
Merged
5 tasks
@davorpa davorpa added the conflicts Conflict(s) need to be resolved label Nov 3, 2021
@davorpa
Copy link
Member

davorpa commented Nov 3, 2021 •
edited
Loading

ℹ️ Please, don't make force pushes using outdated work. Some review commits has been lost since #5837 (comment). Better a local merge with them

@filoscoder filoscoder changed the title Implementation of CONTRIBUTING translation in Korean Added links to korean docs Nov 3, 2021
@filoscoder
Copy link
Contributor Author

ℹ️ Please, don't make force pushes using outdated work. Some review commits has been lost since #5837 (comment). Better a local merge with them

My bad, revert & fixed formatting issues.
I think my contribution will be adding the missing links to korean docs in other language documentations.

@davorpa davorpa removed conflicts Conflict(s) need to be resolved waiting for changes PR has been reviewed and changes/suggestions requested labels Nov 3, 2021
@davorpa davorpa self-requested a review November 3, 2021 14:20
davorpa
davorpa approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@davorpa davorpa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎆 . Sorry for the long work

@davorpa davorpa added 🚀 ready to merge LGTM. Waiting for final approval and removed New Feature New feature / enhancement / translation... labels Nov 3, 2021
@eshellman
Copy link
Collaborator

Thanks, and welcome to free-programming-books!

@eshellman eshellman merged commit 29b14ac into EbookFoundation:master Nov 3, 2021
@davorpa davorpa mentioned this pull request Nov 3, 2021
Closed
9 tasks
@davorpa davorpa added 🗣️ translations Issues or PRs addresing translations 🗣️ locale:ko Resources addressing "Korean / 한국어 [韓國語]" language New Feature New feature / enhancement / translation... labels Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davorpa davorpa davorpa approved these changes

Assignees

@davorpa davorpa

@filoscoder filoscoder

Labels
New Feature New feature / enhancement / translation... 🚀 ready to merge LGTM. Waiting for final approval 🗣️ locale:ko Resources addressing "Korean / 한국어 [韓國語]" language 🗣️ translations Issues or PRs addresing translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filoscoder @eshellman @davorpa