Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to set class for form_group_class #1339

Closed

Conversation

galiteintechnologies
Copy link

@galiteintechnologies galiteintechnologies commented Oct 18, 2016

To customise form_group_class block, new parameter named class has been used. for ex.

- property: 'name'
  label: 'My name'
  class: 'col-sm-8'
  type: 'text'
  css_class: 'col-sm-4'
  type_options: { attr: {'class': 'col-sm-3 ', 'style': 'background-color:#f9f4d1'}, required: false }

will generate html like:

<div class="col-xs-12 col-sm-4">
    <div class="form-group field-input">
        <label class="col-sm-4 control-label" for="name">My name</label>
        <div class="col-sm-8">
            <input type="text" style="background-color:#f9f4d1" id="name" name="name" class="form-control col-sm-3">
        </div>
    </div>
</div>

I have tried to resolve this issue Ref: https://github.com/javiereguiluz/EasyAdminBundle/issues/1336

@shakaran
Copy link
Contributor

@NexuslinkServices Thanks! LGTM and very elegant resolved ;) I would like see this merged on master soon ;)

@shakaran
Copy link
Contributor

@javiereguiluz ping you here as BUMP the PR, so maybe you can merge to master and make another quick and great release this week ;)

@shakaran
Copy link
Contributor

shakaran commented Nov 8, 2016

@javiereguiluz any chance that this PR could be merged to master in the next days? There are something to modify it or wrong for avoid the merge?

@shakaran
Copy link
Contributor

shakaran commented Apr 5, 2017

@javiereguiluz I am waiting for a merge almost 6 months here (it seems a quick fix), please could you give at least your impressions about if this is ok to merge?

@shakaran
Copy link
Contributor

@javiereguiluz almost a year birthday for merge or review this Pull Request. I know that you are busy with Symfony 4, but yeah, a bit dissapointing.

@javiereguiluz
Copy link
Collaborator

I'm really sorry but I must close this proposal as "won't fix". I apologize for not having closed it earlier and I understand if you are angry about this decision. As explained in #2059, we are going to make trascendental changes very soon to this bundle, so we must merge or close every pull request first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants