Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next steps for this project #2059

Closed
8 of 10 tasks
javiereguiluz opened this issue Feb 18, 2018 · 13 comments
Closed
8 of 10 tasks

Next steps for this project #2059

javiereguiluz opened this issue Feb 18, 2018 · 13 comments

Comments

@javiereguiluz
Copy link
Collaborator

javiereguiluz commented Feb 18, 2018

I'd like to share my plans for the next weeks so the community can double check if I missed something important:

  • 1) Finish the pending features: immutable date types (Added support for immutable date types #2057), allow to add parameters to the rendered template (Simple permissions management using roles #218) and form tabs ( Added form tabs #1887).
  • 2) Declare the 1.x branch of the bundle as "finished". No more features for it.
  • 3) Release a new 1.x stable version.
  • 4) Move the repository from https://github.com/javiereguiluz/EasyAdminBundle to https://github.com/EasyCorp/EasyAdminBundle. That will be transparent for end-users because GitHub does this redirection internally for everything: code, downloads, issues, PRs, etc.
  • 5) Rename the Composer package from javiereguiluz/easyadmin-bundle to easycorp/easyadmin-bundle. Sadly in this step we'll lose all downloads and history on Packagist because they don't support transparent renaming (see Transparent renaming of packages composer/packagist#876)
  • 6) Rename the Symfony Flex recipe for the new vendor.
  • 7) In the new repository, create a 1.x branch where we'll only merge bug fixes (no new features) until the end of November 2018, which is when Symfony 2.8 reaches end of bug fix support.
  • 8) Update the bundle doc on symfony.com to keep publishing its docs (new vendor, new repo, new branch, etc.)
  • 9) In the new repository the master branch will be considered the 2.x version, which will require PHP 7.1 and Symfony 4. The plan is to:
    a) Remove all legacy and deprecated features needed to support non Symfony 4 versions.
    b) Refactor all PHP code to use every new PHP 7.1 feature.
    c) Release as soon as possible the 2.0.0 version.
    d) Create a new Symfony Flex recipe for 2.0 version.
  • 10) Once 2.0.0 version is released with new PHP 7.1 code and no legacy features, start working on the main new features. First of all: add security options to control which menu options are displayed to users, etc.
@yceruto
Copy link
Collaborator

yceruto commented Feb 18, 2018

That's good news! I'll be happy to help and because soon we'll reach the 2000 stars. Good luck for 2.x!

@jazithedev
Copy link
Contributor

Great news! At last new major version :). And can't wait for "form tabs" to be implemented.

@aminebenhariz
Copy link
Contributor

@javiereguiluz, I'm available if you need any help.
I love this bundle, and I want to contribute to it. Feel free to assign me some tasks.

This was referenced Feb 21, 2018
@javiereguiluz
Copy link
Collaborator Author

For those who want to help, I'm creating issues with the label help wanted: help wanted Issues and PRs which are looking for volunteers to complete them. They are small and actionable issues. If you want to take any of them and don't understand anything, please ask! Thanks!

@soullivaneuh
Copy link
Contributor

About Symfony v4, I'm nearly sure you can also support SF 3.4 without any issue. See also #2135

@javiereguiluz
Copy link
Collaborator Author

@soullivaneuh yes, we could ... but I prefer to not make that effort. For the ultra-legacy support for Symfony 2 to 3 and 4, we have the 1.x branch. I want 2.x to be Symfony 4 only and move quickly the requirements to be inline with the latest Symfony. We're transforming this bundle from ultra-legacy to cutting-edge :)

@alterphp
Copy link
Contributor

alterphp commented Apr 2, 2018

@javiereguiluz For the security access control feature, have a look at this implementation : https://github.com/alterphp/EasyAdminExtensionBundle#define-access-permissions

Menu only show accessible entries (and empty menu groups are pruned), list only show accessible actions and controllers send ForbiddenException if access is denied. Pure role-based access-control.

@gonzalovilaseca
Copy link

@javiereguiluz I'd like to contribute to this repo, please let me know if there is any specific thing I can help with.

@c33s
Copy link

c33s commented Jun 30, 2018

@javiereguiluz any chance for support for sf 3.4 (with flex and sf4.0 dir structure)? i think it is really important to supprot LTS versions of symfony. it is quite a bad DX if you choose to go with LTS to have a long and stable support for symfony but the bundles you need does not support them.
of course there is the 1.x branch but as you declared it feature complete and don't accept any more PR (as far as i understand), we won't have features we need in it (like supporting multiple sort fields via yaml #2054)

@TomasVotruba
Copy link
Contributor

Let me know if you need upgrade to PHP 7.1.
I do it routinely :)

@xabbuh
Copy link
Collaborator

xabbuh commented Aug 18, 2018

@TomasVotruba The master branch already requires PHP >=7.1.3. :)

@TomasVotruba
Copy link
Contributor

Does that mean "go for it"? :)

@javiereguiluz
Copy link
Collaborator Author

I'm closing here because the plan has been explained and we just need to finish the last steps. Thanks!

For now I'd prefer to not change the master branch code much to not introduce conflicts with 1.x while we maintain it for some time (only for bugfixes). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants