Question: Shouldn't v1.17.13 has been v1.18.1? (being more semver?)

[c33s]

upgrading from 1.17.12 to 1.17.13 broke my admin because of #2281 (which is probably fixed by: #2262)

the comparision of v 1.17.12 and 1.17.13 shows a lot of changes, which don't look as patch to me (on only skimming over the diff), they are at least minor. according to the comment of @hason it is a BC break which even would be a major cahnge which would have to result in 2.0.0 version (i assume that easyadmin is using semver, is it?).

of course errors happen, this is normal but maybe we should be more careful what we integrate in a patch version, so that people can blindly update patch versions.

@javiereguiluz as there are quite some bugs and missing feature in 1,x and as easyadmin is the "official" admin of symfony, we would need bugfixes and feature backports to the 1.x branch or as i commented in the other issue support for symfony 3.4 with easyadmin 2.0 (at least if the 4.0 directory structure is used). also it would be interesting who are the main decision-maker of this project now? the withdraw of your person from this awesome project, maybe left a vacuum, which maybe needs to be filled.

[xabbuh]

according to the comment of @hason it is a BC break which even would be a major cahnge which would have to result in 2.0.0 version (i assume that easyadmin is using semver, is it?).

If that was an intentional BC break, I would agree with you. However, this BC break was never intended, but it was just a regression introduced in #2249. I am sorry for that, but mistakes happen and with #2262 being merged, this regression will be reverted.

also it would be interesting who are the main decision-maker of this project now? the withdraw of your person from this awesome project, maybe left a vacuum, which maybe needs to be filled.

Can you point to where Javier declared to withdraw from this project? I haven't heard of that. It looks like some misunderstanding to me.

[c33s]

@xabbuh of course it was not intentional, i tried to express that i know that with:

of course errors happen...

just wanted to say we should be more careful and that so many changes. also performance optimizations should not be part of a patch release (only if there was a bug which make the bundle so slow, that it is unuseable). as far as i understand it, the PR #2249 would have made it in the patch release if it wouldn't have been a BC break (the merge of the bc break was an accident), where it should be a minor release because not only bug fixes are in it.

maybe i used the wrong vocabulary, with withdraw i mean not completly withdraw, just a part withdraw. in the new organization i only see contributors and no members, before it was javiers project and he was the main contact person. i only read that he has not so much time now, which i can fully understand, and theirfor easyadmin was transfered to this organisation.
i struggle myself to be a good opensource contributor and still be able to getting my work done.

[javiereguiluz]

@c33s yes, lately I didn't have much time for this project. However, don't worry much. I personally use this project in lots of important things. I depend on this project AL LOT, so I have a strong interest in keeping it alive. That's the best guarantee for its future. Cheers!