Update docker recipe to install from source #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 12, 2020 10:24
…to update_docker
…to update_docker
|
Can not be merge until ESMValGroup/ESMValCore#603 is merged |
|
ESMValGroup/ESMValCore#603 has now been merged. |
added 2 commits
July 3, 2020 14:26
bouweandela
reviewed
Jul 8, 2020
bouweandela
reviewed
Jul 8, 2020
bouweandela
reviewed
Jul 8, 2020
bouweandela
reviewed
Jul 8, 2020
bouweandela
reviewed
Jul 8, 2020
bouweandela
reviewed
Jul 8, 2020
bouweandela
reviewed
Jul 8, 2020
bouweandela
reviewed
Jul 8, 2020
added 2 commits
July 11, 2020 11:12
bouweandela
reviewed
Jul 22, 2020
bouweandela
reviewed
Jul 22, 2020
bouweandela
reviewed
Jul 27, 2020
docker/Dockerfile.dev
Outdated
|
|
||
| RUN conda update -y conda pip && conda env update --name base --file environment.yml && conda clean --all -y | ||
| RUN pip install . && pip cache purge | ||
| RUN apt install julia -y && julia esmvaltool/install/Julia/setup.jl |
There was a problem hiding this comment.
To fix the julia diagnostics, I think you need to run the installed version of the setup.jl script here, not the one from the source code. Or install the tool in editable mode with pip -e.
There was a problem hiding this comment.
Can you test again, please?
bouweandela
reviewed
Jul 27, 2020
bouweandela
reviewed
Jul 27, 2020
bouweandela
reviewed
Jul 27, 2020
|
The key to reduce the image size is to properly set the .dockerignore file, but I'm struggling with it |
|
It works with -e option... |
added 2 commits
July 28, 2020 17:43
bouweandela
reviewed
Jul 30, 2020
bouweandela
reviewed
Jul 30, 2020
bouweandela
reviewed
Jul 30, 2020
bouweandela
reviewed
Jul 30, 2020
bouweandela
reviewed
Jul 30, 2020
Co-authored-by: Bouwe Andela <[email protected]>
bouweandela
approved these changes
Aug 3, 2020
bouweandela
added a commit
that referenced
this pull request
Aug 3, 2020
* Update docker files * Add esmvaltool install command * Upload coverage for regular unit tests Co-authored-by: Bouwe Andela <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you start, read CONTRIBUTING.md and the guide for diagnostic developers.
Please discuss your idea with the development team before getting started, to avoid disappointment later. The way to do this is to open a new issue on GitHub. If you are planning to modify an existing functionality, please discuss it with the original author(s) by tagging them in the issue.
Tasks
yamllintto check that your YAML files do not contain mistakesIf you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
Closes #1579