Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERA5 CMORization by recipe #1432

Merged
merged 26 commits into from
Feb 13, 2020
Merged

ERA5 CMORization by recipe #1432

merged 26 commits into from
Feb 13, 2020

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Nov 7, 2019

CMORizer associated with ESMValGroup/ESMValCore#358

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • Give this pull request a descriptive title that can be used as a one line summary in a changelog
  • Make sure your code is composed of functions of no more than 50 lines and uses meaningful names for variables
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes

Related to ESMValGroup/ESMValCore#447

@bouweandela bouweandela mentioned this pull request Nov 7, 2019
12 tasks
@bouweandela bouweandela mentioned this pull request Nov 13, 2019
@mattiarighi mattiarighi changed the base branch from version2_development to master January 3, 2020 17:55
@bouweandela
Copy link
Member Author

@Peter9192 Could you please have a look at why the documentation build is failing? You can build the documentation locally as described here (make sure you've installed esmvaltool with pip install -e '.develop' so sphinx is also installed).

@Peter9192 Peter9192 marked this pull request as ready for review February 1, 2020 11:02
@mattiarighi
Copy link
Contributor

Please revert the changes in recipe_check_obs.yml (all entries are currently commented out).

@mattiarighi
Copy link
Contributor

It might be useful to update config-user-example.yml with a native6 entry.

@mattiarighi
Copy link
Contributor

Please fix the Codacy issues (that should also fix the tests).

@mattiarighi
Copy link
Contributor

@bascrezee this should supersede #1280.

@hb326 this should supersede #1332.

If so, please close those PRs and delete the respective branches. Thanks!

@bouweandela
Copy link
Member Author

Note that a new release of ESMValCore is needed before the unit tests can pass/this can be merged.

@mattiarighi mattiarighi self-requested a review February 7, 2020 11:23
@mattiarighi
Copy link
Contributor

Waiting for the next core release before merging.

@Peter9192
Copy link
Contributor

Peter9192 commented Feb 12, 2020

Making a new issue/PR (#1522/#1523) for broken tests/recipes. These are unrelated to the current PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants