ERA-Interim Land

[bascrezee]

Another addition to the ERA family. Note that the code is very similar to ERA5. A combination of the ERA family to avoid code duplication is under discussion in #1314 and #1312. I needed this functionality right now, so I added it. Depending on the outcome of our discussion we might want to combine several PRs into a single one for the ERA family of datasets.

[bouweandela]

Hi Bas,

Maybe you could have a look at the ERA-Interim cmorizer and re-use that?

I think you could add your variable to the download script here: https://github.com/ESMValGroup/ESMValTool/blob/version2_development/esmvaltool/cmorizers/obs/download_scripts/download_era_interim.py, I think you could just just add a function that looks something like

_get_land_data(LAND_PARAMS, LAND_TIMESTEPS, years, server, era_interim_land_dir)

or something.

Ideally you could maybe simply re-use the complete cmorizer script by making the content of cmorize_obs_era_interim_land.py just from .cmorize_obs_era_interim import cmorization.

Do you think that could work?

I would also suggest the name ERA-Interim-Land for the dataset, that makes it consistent with the naming for ERA5 and ERA5-Land in the CDS.

[bascrezee]

I added the download option in #1423 and will implement the other changes in this PR.

[bascrezee]

Your suggested approach seems to work! pylint doesn't like it, but I guess we don't care about that in this very particular case.

I do still get an error though, but the cause might be somewhere else:

2019-11-04 13:46:41,863 [29534] INFO     esmvaltool.cmorizers.obs.cmorize_obs_era_interim,297	CMORizing variable 'sm' from input files '/PROJECTS/C3S/datadir/rawobsdir/Tier3/ERA-Interim-Land/eraintland_swvl1_2010.nc'
concurrent.futures.process._RemoteTraceback: 
"""
Traceback (most recent call last):
  File "/conda/envs/esmvaltool-public/lib/python3.7/concurrent/futures/process.py", line 232, in _process_worker
    r = call_item.fn(*call_item.args, **call_item.kwargs)
  File "/home/ESMValTool/esmvaltool/cmorizers/obs/cmorize_obs_era_interim.py", line 309, in _extract_variable
    cube.standard_name = definition.standard_name
  File "/conda/envs/esmvaltool-public/lib/python3.7/site-packages/iris/_cube_coord_common.py", line 128, in standard_name
    raise ValueError('%r is not a valid standard_name' % name)
ValueError: '' is not a valid standard_name

[bouweandela]

I fixed the two issues mentioned above.

[bascrezee]

This PR extends the current cmorizer for ERA-Interim to also include ERA-Interim-Land.

[mattiarighi]

@bouweandela can I test it or do you have further comments?

[mattiarighi]

Just for updating our DKRZ/Jasmin pool, which time frame do you plan to use for this dataset?

[bascrezee]

Just for updating our DKRZ/Jasmin pool, which time frame do you plan to use for this dataset?

1988 to 2010