Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CIME Directories agsalin/mkdir_src #1186

Merged
merged 17 commits into from
Mar 2, 2017
Merged

Conversation

agsalin
Copy link
Contributor

@agsalin agsalin commented Feb 23, 2017

Re-organization of CIME directory structure based on Issue #1178 discussion.

Separate commits on this branch for each step -- tests pass at each stage:

  1. Move components, driver_cpl,share, externals into new src dir.
  2. Move buildlib.xxxx files from cime_config to src/build_scripts
  3. Rename cime_config to config
  4. Rename driver_cpl to drivers/mct and rename drivers/mct/driver to drivers/mct/main
  5. Rename shr_RandNum to RandNum
  6. Rename csm_share/share to csm_share/util
  7. Move contents of share/csm_share up a level into share, and rmdir csm_share (retain library of that name)
  8. Remove CIME/tests and CIME/scripts/Testing dirs -- unused per discussion
  9. Move utils/python to scripts/lib
  10. Move scripts/libs/tests up to scripts/tests (where scripts_regression_tests.py lives) and Move utils/data_assimilation to scripts/data_assimilation.

Test suite: scripts/tests/scripts_regression_tests.py
Test baseline: N/A
Test namelist changes: N/A
Test status: bit for bit

Fixes #1178
Fixes #1150

User interface changes?: No

Code review:

As discussed in issues #1178 and #1150, the
four model source directories are moved to
a CIME/src directory. This is intended to help
people navigate cime more easily.

The changes are mainly in xml config:
  $CIMEROOT/externals -> $CIMEROOT/src/externals
repeated for driver_cpl, share, components.

Also, many changes in python to add src to the
relative directory path.

scripts_regression_tests all pass
Move buildib.gptl, mct, etc. scripts from
cime_config to src/build_scripts.
Per discussion on #1178

I used "git mv cime_config config" so history
will be intact.

I ran 2 tests to confirm. Need to really test
in acme and cesm since many changes in allactive.
  git mv  driver_cpl drivers/mct
and down one level,
  git mv driver main
Moved all 4 subdirs from share/csm_share into share/ itself.

Per discussion on issue #1178.

Note: retained "csm_share" library name. At some
point this should be renamed "cime_share," but
this might be a requore changing component
build systems.
Per discussion around #1178 and 2/22/17 meeting notes.
What was utils/python/tests, and previously
moved to scripts/lib/tests recent commit, now
moved to scripts/test.

Also, move data_assililation
from utils to scripts.
@agsalin
Copy link
Contributor Author

agsalin commented Feb 24, 2017

I think I did everything we discussed, as we decided. Only the data_assimilation move from utils to scripts was extra.

I will start looking into how much work will be needed in ACME to match this change (and in CESM by analogy).

Copy link
Contributor

@jedwards4b jedwards4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run scripts_regression_tests.py on yellowstone (all pass) and the fortran unit tests, after fixing a few paths in CMakeLists.txt files they all pass too. Nice work, thanks!

* master:
  Add some comments
  fix pylint problems
  Revert "Revert "add --mpilib option to create_test"" Not sure how the first revert got there This reverts commit 6bb7d0b.
  break up config_archive into component specific files
  Revert "add --mpilib option to create_test"
  Change driver and share code to use new shr_assert interface
  Allow passing file and line to shr_assert
  Update ChangeLog
  Add S-case test to cime_developers
  update to resolve problem with merge and PR #1159
  add --mpilib option to create_test
  make sure pio1 finds netcdf4
  Tweak ChangeLog text
  Update ChangeLog for cime5.2.0-alpha.25
  Revert "update case_lt_archive python implimentation"
  update case_lt_archive python implimentation
  remove cime_config/cesm/allactive from CIME and replace it with an external
  changes to get pop namelists working with user_nl_pop changes
@jgfouca jgfouca self-assigned this Feb 24, 2017
fischer-ncar and others added 5 commits February 27, 2017 14:58
Merged in changes from 1188 into this mkdir_src
branch. Updated all paths to renamed directory
structure.
Several config_archive.xml files appeared
after merge with master. Moving them to
new location.
@jedwards4b jedwards4b merged commit 6f918b5 into master Mar 2, 2017
@jgfouca jgfouca deleted the agsalin/mkdir_src branch March 21, 2017 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants