Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group fortran code directory within src directory #1178

Closed
agsalin opened this issue Feb 22, 2017 · 2 comments
Closed

Group fortran code directory within src directory #1178

agsalin opened this issue Feb 22, 2017 · 2 comments
Assignees

Comments

@agsalin
Copy link
Contributor

agsalin commented Feb 22, 2017

Breaking out discussion from #1150

I propose a small clean-up of the top-level CIME dir by moving
externals, share, driver_cp, components
within a directory called src. Also, the buildlib.* files for compiling these libraries will be moved from cime_config to src.

Regarding comments from #1150

  • I like the name "src" over "source" because it is commonly used for source code, such as in virtually all ACME (and presumably CESM) components like cam, clm, cice, mosart.
  • I don't think that CIME infrastructure source (i.e. python) belongs here. To me, there is a distinction between infrastructure source code and model source. common_model_source_code
@agsalin agsalin self-assigned this Feb 22, 2017
agsalin added a commit that referenced this issue Feb 22, 2017
As discussed in issues #1178 and #1150, the
four model source directories are moved to
a CIME/src directory. This is intended to help
people navigate cime more easily.

The changes are mainly in xml config:
  $CIMEROOT/externals -> $CIMEROOT/src/externals
repeated for driver_cpl, share, components.

Also, many changes in python to add src to the
relative directory path.

scripts_regression_tests all pass
@mvertens
Copy link
Contributor

mvertens commented Feb 22, 2017 via email

@rljacob
Copy link
Member

rljacob commented Feb 22, 2017

From discussion on telecon. Changes to above:
/CIME/src/drivers/mct/driver -> /CIME/src/drivers/mct/main
/CIME/src/share/shr -> ~/CIME/src/share/util
/CIME/src/share/shr_RandNum -> ~/CIME/src/share/RandNum

Other proposals (copied over from meeting notes):
CIME/utils/python -> CIME/scripts/lib. Still need CIME/scripts/lib/CIME without major search/replace. CIME/utils/python/tests -> CIME/scripts/tests/
Remove CIME/scripts/Testing
CIME/cime_config/buildlib*. Andy will move to src/buildscripts/. Jim is rewriting in python.
Remove cime/tests

agsalin added a commit that referenced this issue Feb 23, 2017
Per discussion on #1178

I used "git mv cime_config config" so history
will be intact.

I ran 2 tests to confirm. Need to really test
in acme and cesm since many changes in allactive.
agsalin added a commit that referenced this issue Feb 23, 2017
agsalin added a commit that referenced this issue Feb 23, 2017
agsalin added a commit that referenced this issue Feb 23, 2017
Moved all 4 subdirs from share/csm_share into share/ itself.

Per discussion on issue #1178.

Note: retained "csm_share" library name. At some
point this should be renamed "cime_share," but
this might be a requore changing component
build systems.
agsalin added a commit that referenced this issue Feb 23, 2017
Per discussion around #1178 and 2/22/17 meeting notes.
@ghost ghost added the in progress label Feb 23, 2017
@ghost ghost removed the in progress label Mar 2, 2017
@ghost ghost assigned rljacob Mar 23, 2017
@ghost ghost added the in progress label Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants