Remove options not used, e.g. use_fates, use_cndv, and many more #46

slevis-lmwg · 2022-10-13T21:30:14Z

Resolves #44 (I will continue updating my notes there for now)
Resolves #50

Collaborators: @ekluzek

Instead of rerunning the full SLIM test-suite, I have been confirming that the following test continues to PASS, including against the slim-n09_cesm2.1.4 baseline: SMS.f19_g16.H_MML_2000_CAM6.cheyenne_intel.clm-global_uniform_g16_SOM

Testing: same as in previous commit

Same testing as for last two commits

Two tests failed in cheyenne test-suite (looks like same error to me): SMS_D.f19_g17.IHistClm45BgcQianGs.cheyenne_gnu.clm-realistic_fromCLM5_1850 SMS_D_Lm1.f19_g17.I2000SlimRsGs.cheyenne_gnu.clm-2000_CMIP6_AMIP_1deg_ensemble Both passed when I submitted separately.

ekluzek

This is great. It's hard to review these type of changes since they are so extensive. My main question is about the testing done.

We'll talk more at the standup this afternoon...

Cheyenne test-suite is currently running for this commit. For the previous most recent commit, this test passed (no other testing performed): SMS_D.f19_g17.IHistClm45BgcQianGs.cheyenne_gnu.clm-realistic_fromCLM5_1850

SMS_D_Lm1.f19_g17.I2000SlimRsGs.izumi_nag.clm-2000_CMIP6_AMIP_1deg_ensembleMonthly I will submit the full test-suite at the end of today.

…slim_slevis Fix izumi gnu test-suite failure

- izumi gnu test-suite OK - /bld cleanup mostly (if not entirely) NOT done - pftconMod unchanged to avoid paramfile-related failure

izumi gnu test-suite OK

SMS_Ld400.f19_g17.IHistSlim50QianGs.izumi_intel.clm-realistic_fromCLM5_1850Monthly

Rm orbital code that I missed in the previous commit

ekluzek · 2022-10-26T03:17:02Z

With #50 I showed that it's safe to remove use_cn and BGC code.

slevis-lmwg · 2022-10-26T22:44:14Z

cime_config/testdefs/testlist_clm.xml

@@ -106,31 +106,6 @@
  <!-- Run restart tests for important ones, also do ERP for other compsets -->
  <!-- Eventually we should also do ERI tests to make sure branch and hybrid work, but with #19 we can't -->
  <!-- Run one longer test with production compiler for a few years  to make sure longer science runs will continue to work -->
-  <!-- The important science simualtions for this configuration is the IHistClm45BgcQianGs case for Marysa -->
-  <test name="SMS_D" grid="f19_g17" compset="IHistClm45BgcQianGs" testmods="clm/realistic_fromCLM5_1850">


@marysa are transient (eg. IHist) cases of much interest when using SLIM? I'm asking to determine whether we need extensive testing for transient cases.

@ekluzek wanted me to specify that the question pertains to I-cases, not F-cases.

At this morning's SLIM stand-up, @marysa said that we may eventually use IHist with SLIM, so let's keep an IHist test in the test-suite.

slevis-lmwg · 2022-10-26T22:50:02Z

cime_config/testdefs/testlist_clm.xml

-      <option name="comment">Debug smoke test for standalone SLIM</option>
-    </options>
-  </test>
-  <test name="PEM" grid="f19_g17" compset="IHistClm45BgcQianGs" testmods="clm/realistic_fromCLM5_1850">


Keep a PEM test but with I1850

slevis-lmwg · 2022-10-26T22:51:32Z

cime_config/testdefs/testlist_clm.xml

@@ -141,65 +116,6 @@
      <option name="comment">Longer smoke test for standalone SLIM, go over at least a year boundary (with clm5_0 and SP to ensure same as above)</option>
    </options>
  </test>
-  <test name="ERS_D_Ld60" grid="f19_g17" compset="IHistClm45BgcQianGs" testmods="clm/realistic_fromCLM5_1850Monthly">


Keep an ERS_D_Ld60 test but for I1850

slevis-lmwg · 2022-10-26T22:58:39Z

cime_config/testdefs/testlist_clm.xml

-      <option name="comment">Longer smoke test for historical case for SLIM on izumi</option>
-    </options>
-  </test>
-  <test name="SMS" grid="f19_g17" compset="I1850Clm45BgcGs" testmods="clm/realistic_fromCLM5_1850">


Keep SMS for I1850 and remove for I2000

All these test changes should be pushed to the branch separately first, so that I generate new baselines.

...and make a new tag at the same time

@ekluzek
I tried to push the test changes that we discussed to the branch and got this error:
remote: Permission to ESCOMP/SimpleLand.git denied to slevisconsulting
Is this something that you can resolve?

I actually need @marysa to up some permissions. But, once she does that I'll be able to fix that. So you were pushing this part directly to the cesm2_1_slim branch rather than your cesm2_2_slim_slevis branch on your fork? There shouldn't be a problem pushing to your fork, but there would be to the cesm2_1_slim branch.

OK, we've got this figured out @slevisconsulting. Go ahead and try again it should work now.

SMS_D_Lm1.f19_g17.I2000SlimRsGs.cheyenne_gnu.clm-2000_CMIP6_AMIP_1deg_ensembleMonthly SMS_D_Lm1.f19_g17.I2000SlimRsGs.cheyenne_intel.clm-2000_CMIP6_AMIP_1deg_ensembleMonthly Investigating...

Answers didn't change. Reason for going with coldstart: The corresponding tests were aborting with variable not found in initInterpMultilevelContainer.F90 lines 106-114, failing to find coord_varname = 'COL_Z' and/or level_class_varname = 'LEVGRND_CLASS'. Instead of reintroducing code that ultimately is unnecessary to SLIM just to get this function to work, I decided to use coldstart for these tests.

slevis-lmwg · 2022-12-09T19:47:37Z

Most recent git ls-files | xargs wc -l gives 53288.

slevis-lmwg · 2022-12-09T22:11:19Z

New baselines: slim-n11_cesm2.1.4
New tag: slim0.1.007_release-cesm2.1.4

slevis-lmwg added 5 commits October 10, 2022 15:40

Rm use_dynroot, use_grainproduct, use_nguardrail

470bb1d

Testing: same as in previous commit

Rm use_extralakelayers, use_vancouver, use_mexicocity

0a8b99a

Same testing as for last two commits

Rm use_luna

ffd9867

ekluzek approved these changes Oct 14, 2022

View reviewed changes

ekluzek marked this pull request as ready for review October 14, 2022 18:02

slevis-lmwg added 18 commits October 14, 2022 18:49

Rm use_fun; see below for testing notes

dbb3745

Cheyenne test-suite is currently running for this commit. For the previous most recent commit, this test passed (no other testing performed): SMS_D.f19_g17.IHistClm45BgcQianGs.cheyenne_gnu.clm-realistic_fromCLM5_1850

Rm use_nitrif_denitrif; izumi test-suite pgi PASS, others in progress

ac75714

Rm use_vertsoilc; izumi test-suite OK (same results as before)

0306d85

Rm use_century_decomp; izumi test-suite in progress

cffbbf8

Rm use_bedrock, use_flexibleCN; the following nag test passed:

ffda386

SMS_D_Lm1.f19_g17.I2000SlimRsGs.izumi_nag.clm-2000_CMIP6_AMIP_1deg_ensembleMonthly I will submit the full test-suite at the end of today.

Rm camdenNJ asphaltjungleNJ urbanc_alpha numaIA smallvilleIA options

18bd631

Getting izumi gnu test-suite to work

72314c2

Merge commit '72314c2bed1e3f6cc947f47934782929547ebbfb' into cesm2_1_…

9c3d5f0

…slim_slevis Fix izumi gnu test-suite failure

Rm irrig, npcropmin, npcropmax incomplete; details:

3ef05e8

- izumi gnu test-suite OK - /bld cleanup mostly (if not entirely) NOT done - pftconMod unchanged to avoid paramfile-related failure

Rm irrig, npcropmin, npcropmax complete; izumi gnu test-suite OK

80436d2

Rm use_crop and vestiges of c13 & c14 code (incomplete); testing:

8027739

izumi gnu test-suite OK

Rm use_crop (complete); izumi gnu test-suite OK

524f092

Some clean-up for the following izumi intel test to pass:

e8d6c19

SMS_Ld400.f19_g17.IHistSlim50QianGs.izumi_intel.clm-realistic_fromCLM5_1850Monthly

Rm drydep, though not all because tied to lnd2atm; not tested

2c30b33

Rm ozone-related code; izumi test-suites OK

fca445d

Rm misc. items including some ch4, lake, drydep, c13/c14

8c5aa6d

Rm orbital params; izumi gnu test-suite ok

81ad59e

Rm param-file code; start removing use_cn & bgc code; elim. bgc tests

7f5a972

Rm orbital code that I missed in the previous commit

slevis-lmwg commented Oct 26, 2022

View reviewed changes

slevis-lmwg added 20 commits November 30, 2022 17:04

Rm nbedrock; cheyenne gnu ERS test OK

3a0f9e3

Rm more bedrock stuff; cheyenne gnu ERS test OK

8eba3af

Rm SoilHydrology stuff; cheyenne gnu ERS test OK

037b77d

Rm SoilHydrology* & parts of SoilState*; cheyenne gnu ERS test OK

7a52b72

Rm some of SoilState*; cheyenne gnu ERS test OK

a61e2a9

Rm more SoilState*; cheyenne gnu ERS test OK

8cd7ca1

Rm most SoilState*; cheyenne gnu ERS test OK

360bc8e

Begin to rm h2osoi_vol_col; cheyenne gnu ERS test OK

b96e5ee

Rm SoilState* + some WaterStateType; cheyenne gnu ERS test OK

27d7361

Rm most InitAcc* & UpdateAcc* subroutines; cheyenne gnu ERS OK

ebc001a

Rm much of SurfaceAlbedoType; cheyenne gnu ERS test OK

8f32bc1

Rm most of TemperatureType; cheyenne gnu ERS test OK

edf86dd

Rm most EnergyFluxType + SolarAbsorbedType; cheyenne gnu ERS test OK

3588ff1

Rm FrictionVelocityMod & subroutines rhoSat + lnd2atm; same ERS test OK

9eb38c8

Rm atm2lndMod, also a few more variables; cheyenne gnu ERS test OK

32264d8

Rm SolarAbsorbed, Waterflux, parts of TopoMod; cheyenne gnu ERS test OK

8e9a84f

Rm atm2lnd_params_* and related code; cheyenne gnu ERS test OK

f425f29

Rm part of atm2lndType; cheyenne gnu ERS test OK

d1e5c0b

Rm more of atm2lndType; cheyenne gnu ERS test OK

f7d12dd

Rm fert_cft and miscellaneous clean-up; cheyenne gnu ERS test OK

05971e4

slevis-lmwg mentioned this pull request Dec 7, 2022

Restart failed with error "longwave down is 0 or negative" NGEET/fates#935

Closed

slevis-lmwg added 2 commits December 8, 2022 12:19

Miscellaneous clean-up; cheyenne test-suite one test fails per compiler

828d42b

SMS_D_Lm1.f19_g17.I2000SlimRsGs.cheyenne_gnu.clm-2000_CMIP6_AMIP_1deg_ensembleMonthly SMS_D_Lm1.f19_g17.I2000SlimRsGs.cheyenne_intel.clm-2000_CMIP6_AMIP_1deg_ensembleMonthly Investigating...

slevis-lmwg self-assigned this Dec 9, 2022

slevis-lmwg merged commit 0f5a42e into ESCOMP:cesm2_1_slim Dec 9, 2022

slevis-lmwg deleted the cesm2_1_slim_slevis branch December 9, 2022 20:00

slevis-lmwg mentioned this pull request Dec 15, 2022

A list of atm2lnd and lnd2atm variables that's initialized by the CTSM, affects SLIM output #59

Closed

ekluzek mentioned this pull request Dec 16, 2022

Remove use of fsurdat and paramfile in SLIM #56

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove options not used, e.g. use_fates, use_cndv, and many more #46

Remove options not used, e.g. use_fates, use_cndv, and many more #46

slevis-lmwg commented Oct 13, 2022 •

edited

Loading

ekluzek left a comment

ekluzek commented Oct 26, 2022

slevis-lmwg Oct 26, 2022

slevis-lmwg Oct 26, 2022

slevis-lmwg Oct 28, 2022

slevis-lmwg Oct 26, 2022

slevis-lmwg Oct 26, 2022

slevis-lmwg Oct 26, 2022

slevis-lmwg Oct 26, 2022

slevis-lmwg Oct 26, 2022

slevis-lmwg Oct 28, 2022

ekluzek Oct 28, 2022

ekluzek Oct 28, 2022

slevis-lmwg commented Dec 9, 2022

slevis-lmwg commented Dec 9, 2022

Remove options not used, e.g. use_fates, use_cndv, and many more #46

Remove options not used, e.g. use_fates, use_cndv, and many more #46

Conversation

slevis-lmwg commented Oct 13, 2022 • edited Loading

ekluzek left a comment

Choose a reason for hiding this comment

ekluzek commented Oct 26, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

slevis-lmwg commented Dec 9, 2022

slevis-lmwg commented Dec 9, 2022

slevis-lmwg commented Oct 13, 2022 •

edited

Loading