Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop running 0th timestep #67

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Stop running 0th timestep #67

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d0a183
0th timestep fixes
olyson Jun 15, 2023
9d24b69
Remove instances of !KO
olyson Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/riverroute/RtmHistFile.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -983,8 +983,9 @@ subroutine RtmHistHtapesWrapup( rstwr, nlend )
! and write data to history files if end of history interval.
do t = 1, ntapes

! Skip nstep=0 if monthly average
if (nstep==0 .and. tape(t)%nhtfrq==0) cycle
!KO ! Should no longer be needed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to leave commented code here. Please remove.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

!KO ! Skip nstep=0 if monthly average
!KO if (nstep==0 .and. tape(t)%nhtfrq==0) cycle

! Determine if end of history interval
tape(t)%is_endhist = .false.
Expand Down
5 changes: 4 additions & 1 deletion src/riverroute/RtmTimeManager.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1000,7 +1000,10 @@ logical function is_first_step()
call ESMF_ClockGet( tm_clock, advanceCount=step_no, rc=rc )
call chkrc(rc, sub//': error return from ESMF_ClockGet')
nstep = step_no
is_first_step = (nstep == 0)
!KO is_first_step = (nstep == 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

!KO
is_first_step = (nstep == 1)
!KO

end function is_first_step

Expand Down