-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop running 0th timestep #67
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the change @olyson. Please remove the comments. They are forever preserved in github.
src/riverroute/RtmHistFile.F90
Outdated
@@ -983,8 +983,9 @@ subroutine RtmHistHtapesWrapup( rstwr, nlend ) | |||
! and write data to history files if end of history interval. | |||
do t = 1, ntapes | |||
|
|||
! Skip nstep=0 if monthly average | |||
if (nstep==0 .and. tape(t)%nhtfrq==0) cycle | |||
!KO ! Should no longer be needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to leave commented code here. Please remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
src/riverroute/RtmTimeManager.F90
Outdated
@@ -1000,7 +1000,10 @@ logical function is_first_step() | |||
call ESMF_ClockGet( tm_clock, advanceCount=step_no, rc=rc ) | |||
call chkrc(rc, sub//': error return from ESMF_ClockGet') | |||
nstep = step_no | |||
is_first_step = (nstep == 0) | |||
!KO is_first_step = (nstep == 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove commented code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Changes needed to stop running 0th timestep.
See CTSM issue ESCOMP/CTSM#925 and PR ESCOMP/CTSM#2084