Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge b4b-dev into master (2024-02-15) #2367

Closed
wants to merge 43 commits into from

Conversation

samsrabin
Copy link
Collaborator

@samsrabin samsrabin commented Feb 15, 2024

Description of changes

Brings in three PRs from b4b-dev to master:

Specific notes

Contributors other than yourself, if any: None

CTSM Issues Fixed (include github issue #):

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Testing performed, if any:

  • clm_pymods testing passed; generated ctsm5.1.dev168 baselines
  • make all (black, pylint, Python unit/system tests) queued

Includes adding a timeout of 60 seconds for requests.get().
Moves some functions from there into 3 new modules:
* ctsm/crop_calendars/check_constant_vars.py
* ctsm/crop_calendars/check_rx_obeyed.py
* ctsm/crop_calendars/convert_axis_time2gs.py
@samsrabin samsrabin self-assigned this Feb 15, 2024
@samsrabin samsrabin added the PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete label Feb 15, 2024
@samsrabin samsrabin marked this pull request as ready for review February 15, 2024 15:58
@samsrabin samsrabin removed PR status: work in progress PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete labels Feb 15, 2024
@samsrabin
Copy link
Collaborator Author

This needs full aux_clm testing, which I didn't do in advance of our attempted walkthrough today. We'll try again next week.

@samsrabin samsrabin closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant