-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge b4b-dev into master (2024-02-15) #2367
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes adding a timeout of 60 seconds for requests.get().
Moves some functions from there into 3 new modules: * ctsm/crop_calendars/check_constant_vars.py * ctsm/crop_calendars/check_rx_obeyed.py * ctsm/crop_calendars/convert_axis_time2gs.py
Do not crash "make all" even if pylint isn't clean
Resolve pylint issues in python/ctsm/.
… to derecho_gnu. derecho_intel doesn't currently work with debug mode on.
…derecho Move FSURDATMODIFYCTSM test to Derecho
Delete history and spurious _FillValue from parameter files
samsrabin
added
the
PR status: ready
PR: this is ready to merge in, with all tests satisfactory and reviews complete
label
Feb 15, 2024
samsrabin
removed
PR status: work in progress
PR status: ready
PR: this is ready to merge in, with all tests satisfactory and reviews complete
labels
Feb 15, 2024
This needs full aux_clm testing, which I didn't do in advance of our attempted walkthrough today. We'll try again next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Brings in three PRs from b4b-dev to master:
Specific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Testing performed, if any:
clm_pymods
testing passed; generatedctsm5.1.dev168
baselinesmake all
(black, pylint, Python unit/system tests) queued