Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"make all" doesn't run black if lint fails #2316

Closed
samsrabin opened this issue Jan 11, 2024 · 1 comment · Fixed by #2353 or #2382
Closed

"make all" doesn't run black if lint fails #2316

samsrabin opened this issue Jan 11, 2024 · 1 comment · Fixed by #2353 or #2382
Assignees
@samsrabin
Labels
bfb bit-for-bit testing additions or changes to tests

Comments

@samsrabin
Copy link
Collaborator

As of ctsm5.1.dev163, make lint errors:

...
Your code has been rated at 8.80/10 (previous run: 8.80/10, +0.00)

make: *** [Makefile:50: lint] Error 30

This means that, when calling make all, the black test isn't reached.

Doing either of the following in python/Makefile fixes the issue:

  1. Add --fail-under=0 to PYLINT_ARGS
  2. Change the order of the tests in all from test lint black to test black lint.
@samsrabin samsrabin added testing additions or changes to tests next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Jan 11, 2024
@samsrabin samsrabin self-assigned this Jan 11, 2024
samsrabin added a commit to samsrabin/CTSM that referenced this issue Jan 30, 2024
@samsrabin
Do not exit 'make all' if pylint fails.
ee7e6f6 
Resolves ESCOMP#2316.
@samsrabin
Copy link
Collaborator Author

Decision in SE mtg 2024-02-08: Do both.

@samsrabin samsrabin removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Feb 8, 2024
This was referenced Feb 8, 2024
Merged
Closed
@samsrabin samsrabin mentioned this issue Feb 22, 2024
Merged
@samsrabin samsrabin added simple bfb bit-for-bit labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samsrabin samsrabin

Labels
bfb bit-for-bit testing additions or changes to tests
Projects
None yet
Milestone
No milestone
1 participant
@samsrabin