Vertical diffusion refactor

[mwaxmonsky]

Tag name:
Originator(s): @mwaxmonsky
Date: 10/30/2024
One-line Summary: Start refactoring of vertical diffusion to be CCPPized
Github PR URL: #1176

Purpose of changes (include the issue number and title text for each relevant GitHub issue):
Start refactoring of vertical diffusion to be CCPPized and outsources solve phase of non-graft decomp solves to atmospheric physics solver.

Describe any changes made to build system:

• Adds the to_be_ccppized directory in atmospheric_physics to source search path

Describe any changes made to the namelist: N/A

List any changes to the defaults for the boundary datasets: N/A

Describe any substantial timing or memory changes: N/A

Code reviewed by:

List all files eliminated:
D src/utils/coords_1d.F90
D src/utils/linear_1d_operators.F90

• Files were moved to atmospheric_physics

List all files added and what they do: N/A

List all existing files that have been modified, and describe the changes:
M .gitmodules
M bld/configure
M src/atmos_phys

• Update atmospheric_physics reference and added new atmospheric_physics directory to search path

M cime_config/config_pes.xml

• Decreasing NTHRDS from 2 to 1 to force single threaded execution as multithreaded execution enables the -smp flag which breaks under OpenMP when running the SE dycore, similar to Prevent users from turning on OpenMP when using the SE dycore #1087

M src/physics/cam/diffusion_solver.F90

• Uses new CCPPized interface for decomp that was moved to atmospheric_physics repo to single solve step.

If there were any failures reported from running test_driver.sh on any test
platform, and checkin with these failures has been OK'd by the gatekeeper,
then copy the lines from the td.*.status files for the failed tests to the
appropriate machine below. All failed tests must be justified.

derecho/intel/aux_cam:

ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s (Overall: FAIL) details:
SMS_Ld1.f09_f09_mg17.FCHIST_GC.derecho_intel.cam-outfrq1d (Overall: FAIL) details:

• pre-existing failure due to HEMCO not having reproducible results issues HEMCO related test failing baseline compare #1018 and HEMCO restart tests fail #856

SMS_D_Ln9.f19_f19_mg17.FXHIST.derecho_intel.cam-outfrq9s_amie (Overall: FAIL)
SMS_D_Ln9_P1280x1.ne0CONUSne30x8_ne0CONUSne30x8_mt12.FCHIST.derecho_intel.cam-outfrq9s (Overall: FAIL)

• pre-existing failures due to build-namelist error requiring CLM/CTSM external update.

derecho/nvhpc/aux_cam: None

izumi/nag/aux_cam:
DAE.f45_f45_mg37.FHS94.izumi_nag.cam-dae (Overall: FAIL) details:

• pre-existing failure -- issue DAE test broken #670

izumi/gnu/aux_cam:
ERP_D_Ln9.ne3pg3_ne3pg3_mg37.FLTHIST.izumi_gnu.cam-outfrq9s (Overall: DIFF) details:
ERP_Ln9_P24x2.f45_f45_mg37.QPWmaC6.izumi_gnu.cam-outfrq9s_mee_fluxes (Overall: DIFF) details:
ERS_Ln9_P24x1.mpasa480_mpasa480.F2000climo.izumi_gnu.cam-outfrq9s_mpasa480 (Overall: DIFF) details:

• new tests are missing baselines

CAM tag used for the baseline comparison tests if different than previous
tag:

Summarize any changes to answers, i.e.,

• what code configurations:
• what platforms/compilers:
• nature of change (roundoff; larger than roundoff but same climate; new
  climate):
  N/A

If bitwise differences were observed, how did you show they were no worse
than roundoff?
N/A

If this tag changes climate describe the run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced, i.e.,

• source tag (all code used must be in the repository):
• platform/compilers:
• configure commandline:
• build-namelist command (or complete namelist):
• MSS location of output:
  N/A

MSS location of control simulations used to validate new climate: N/A

URL for AMWG diagnostics output used to validate new climate: N/A

[peverwhee]

one question

[nusbaume]

Looks good to me! Just had one comment about the current test failures listed in the ChangeLog.

[nusbaume]

I assume these and the other "expected diff" test failures will go away once we do regression tests against cam6_4_043? If not please let me know (as it could indicate something is wrong).

[mwaxmonsky]

Good catch! I just copied these over from the latest tag changelog and was waiting to update it with the info from my runs but it looks like there were errors relating to my build so I'll clean check these out and re-run on Derecho and these should go away and I'll remove these from the log.