perf: use directly IERC165 in inheritance instead of ERC165
#238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CJ42
force-pushed
the
refactor/custom-error
branch
2 times, most recently
from
5ca5fa0
to
7112a50
Compare
CJ42
force-pushed
the
refactor/custom-error
branch
from
7112a50
to
dcfbba4
Compare
CJ42
force-pushed
the
refactor/custom-error
branch
from
dcfbba4
to
8c0ebb6
Compare
CJ42
force-pushed
the
refactor/custom-error
branch
5 times, most recently
from
a0c1c1a
to
b0acce2
Compare
YamenMerhi
requested changes
Oct 5, 2023
Tested and this actually will break the inheritance call via |
skimaharvey
pushed a commit
to skimaharvey/ERC725
that referenced
this pull request
Feb 22, 2024
…ders2 refactor: prepare wrapper utils for provider merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR introduce?
♻️ Refactor
Remove
IERC165from the inheritance list ofIERC725XandIERC725Y.⚡️ Performance
Reduce deployment cost by an extra -45.814 gas compared to #236 by using directly
IERC165in the inheritance instead ofERC165and callingsuper.supportsInterface.The checks for interface ID ERC165 are directly inlined as a result inside the
supportsInterface(bytes4)function ofERC725XCore,ERC725YCoreandERC725contracts.PR Checklist
npm run lint&&npm run lint:soliditynpm run format(prettier)npm run buildnpm run testPrevious gas cost (
developbranch)New Gas costs (this branch)