refactor: use custom error for onlyOwner and address(0) check
#236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeforeAfter |
CJ42
force-pushed
the
refactor/custom-error
branch
from
5953f4a
to
0f97813
Compare
7 tasks
CJ42
force-pushed
the
refactor/custom-error
branch
2 times, most recently
from
68d6a83
to
5ca5fa0
Compare
CJ42
changed the title
address(0) checkonlyOwner and address(0) check
CJ42
force-pushed
the
refactor/custom-error
branch
8 times, most recently
from
3159683
to
a0c1c1a
Compare
CJ42
force-pushed
the
refactor/custom-error
branch
from
a0c1c1a
to
b0acce2
Compare
YamenMerhi
approved these changes
Sep 27, 2023
b00ste
approved these changes
Sep 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR introduce?
0.8.4because of the use of custom errors: https://github.com/ethereum/solidity/releases/tag/v0.8.40.8.5because of the usebytestobytesNconversion: https://github.com/ethereum/solidity/releases/tag/v0.8.5📦 Build
solccompiler version because of full usage of customerror(currently statespragma solidity ^0.8.0⚡️ Performance
Replace revert reason strings with custom errors for
OwnableUnsetandaddress(0)check ontransferOwnership(),constructorandinitialize(address)functions.This reduces the deployment cost of an
ERC725smart contract by -58,427 gas.PR Checklist
npm run lint&&npm run lint:soliditynpm run format(prettier)npm run buildnpm run test