On macOS populate root CAs via system cert store #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a method that can be used within fc’s http_client as well as cleos to populate the HTTPS trusted root certificates based on the system certificate store. This does pose a behavior change for http_client (used within producer_plugin): previously it trusted no root CAs other then the one provided by the user. Now it will trust the system cert store. Much of the logic to implement this function was taken from golang’s lib. I’ve included their license file.
Because keosd connections cannot be kept alive at this time, constantly repopulating HTTPS root certs on each SSL connection is too much overhead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a method that can be used within fc’s http_client as well as cleos to populate the HTTPS trusted root certificates based on the system certificate store.
This does pose a behavior change for http_client (used within producer_plugin): previously it trusted no root CAs other then the one provided by the user. Now it will trust the system cert store.
Much of the logic to implement this function was taken from golang’s lib. I’ve included their license file.