This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
On macOS populate root CAs via system cert store #5886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously on macOS the HTTPS root CAs there were trusted was loaded from the /private/etc/ssl/cert.pem file. This is 1. Not documented or supported 2. Out of date 3. Doesn't honor distrust of certs 4. Doesn't know of user added certs in the keychain Now, populate the root CAs from the keychain. This solves all of the above. This takes affect for both cleos and the http_client used by producer_plugin for out-of-process keosd signing. Note the behavior for http_client has markedly changed: previously it would not consider any root CAs other then the one the user explicitly provided. Now on macOS and Linux it will consider the system certificate store. This behavior can be reverted if it is controversial. Much of the logic behind the macOS keychain cert loading was taken from golang's library. License included as appropriate.
wanderingbort
approved these changes
Oct 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously on macOS the HTTPS root CAs there were trusted was loaded from the /private/etc/ssl/cert.pem file. This is
Now, populate the root CAs from the keychain. This solves all of the above.
This takes affect for both cleos and the http_client used by producer_plugin for out-of-process keosd signing. Note the behavior for http_client has markedly changed: previously it would not consider any root CAs other then the one the user explicitly provided. Now on macOS and Linux it will consider the system certificate store. This behavior can be reverted if it is controversial.
Much of the logic behind the macOS keychain cert loading was taken from golang's library. License included as appropriate.
Goes with EOSIO/fc#26 -- as usual please approve & merge that one first and then the submodule here will be updated.
Fixes #2556