Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

[docs] New threshold for non privileged inline actions #9270

Merged
merged 2 commits into from
Jul 1, 2020

Conversation

bobgt
Copy link
Contributor

@bobgt bobgt commented Jun 30, 2020

New plugin option added to address documentation additions in PR #9262

Change Description

Change Type

Select ONE

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

New plugin option
@bobgt bobgt added the documentation Requires attention from documentation team. e.g. documentation is expected to be generated. label Jun 30, 2020
@bobgt bobgt requested review from lparisc and iamveritas June 30, 2020 19:11
@bobgt bobgt changed the title Doc changes for PR #9262 New threshold for non privileged inline actions Jun 30, 2020
@bobgt bobgt requested a review from johndebord June 30, 2020 19:14
Comment on lines 172 to 173
Sets the maximum limit for non-privileged inline actions.
The default value is 4 KB and if this threshold is exceeded,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not crucial since this is for docs, but it was better to restrict column length to 80 characters like the other entries, especially since this is displayed in a codeblock.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I adjusted the characters. Let me know if it is fine now.

@bobgt
Copy link
Contributor Author

bobgt commented Jul 1, 2020

Hi @johndebord: could you review this?

@johndebord johndebord merged commit 9559895 into develop Jul 1, 2020
@lparisc lparisc changed the title New threshold for non privileged inline actions [docs] New threshold for non privileged inline actions Jul 1, 2020
@lparisc lparisc added the staging doc-related issue has been resolved in merged PR. moved to staging phase for production testing. label Jul 7, 2020
@brianjohnson5972 brianjohnson5972 deleted the docs/max-inline-actions-size branch November 21, 2020 15:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Requires attention from documentation team. e.g. documentation is expected to be generated. staging doc-related issue has been resolved in merged PR. moved to staging phase for production testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants