This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Nonprivileged inline action subjective limit #9262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1bart
suggested changes
Jun 30, 2020
| const static uint32_t default_max_trx_lifetime = 60*60; // 1 hour | ||
| const static uint32_t default_deferred_trx_expiration_window = 10*60; // 10 minutes | ||
| const static uint32_t default_max_trx_delay = 45*24*3600; // 45 days | ||
| const static uint32_t default_max_inline_action_size = 4 * 1024; // 512 KB |
There was a problem hiding this comment.
comment stale from mid-work commit?
There was a problem hiding this comment.
Comment correct. Value inadvertently reverted while working on tests.
7 tasks
Use default value variable in parser for new limit. Set intended new inline action size limit.
heifner
reviewed
Jul 1, 2020
heifner
reviewed
Jul 1, 2020
heifner
reviewed
Jul 1, 2020
heifner
reviewed
Jul 1, 2020
heifner
reviewed
Jul 1, 2020
b1bart
approved these changes
Jul 2, 2020
… match the old default value.
…_action_size in the genesis state.
heifner
reviewed
Jul 7, 2020
…ubjectively on deffered transactions.
heifner
reviewed
Jul 8, 2020
heifner
reviewed
Jul 8, 2020
heifner
reviewed
Jul 8, 2020
heifner
reviewed
Jul 8, 2020
heifner
reviewed
Jul 8, 2020
….com:EOSIO/eos into nonprivileged-inline-action-subjective-limit
heifner
reviewed
Jul 9, 2020
b1bart
approved these changes
Jul 9, 2020
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Add new config file option
max-nonprivileged-inline-action-sizewhich is the cap for the size of an inline action above which a transaction will subjectively fail.Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions
Documentation describing config file options should be updated to include the new
chain_pluginsettingmax-nonprivileged-inline-action-sizewhich is the cap for the size of an inline action above which a transaction will subjectively fail. The default value is 4KB, the same as the previous limit for all inline actions. This PR will change the formermax-inline-action-sizedefault to 512KB for new chains. Existing chains will have to update the setting in the global property object. Themax-inline-action-sizelimit will apply to inline actions from privileged accounts. Exceeding that limit continues to be an objective failure.