Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

NodeJS modules to remove obsolete https-everywhere-checker messages #11963

Closed
wants to merge 1 commit into from
Closed

NodeJS modules to remove obsolete https-everywhere-checker messages #11963

wants to merge 1 commit into from

Conversation

cschanaj
Copy link
Collaborator

Remove obsolete comments from re-activated rulesets.

@cowlicks
Copy link
Contributor

Sorry for my lack of knowledge, but can you explain a little more: What are "https-everywhere-checker" messages? Why are they obsolete? How does this fix that? How does a re-activated ruleset effect this?

Thank you! You're answers will save me a lot of time reviewing this PR.

@cschanaj
Copy link
Collaborator Author

Related to #11561 (comment), https-everywhere-checker disable & comment rulesets in full-fetch test, like

Disabled by https-everywhere-checker because:
Fetch error: http://zoomerang.com/ => https://zoomerang.com/: (60, 'SSL certificate problem: unable to get local issuer certificate')
Fetch error: http://static.zoomerang.com/ => https://static.zoomerang.com/: (28, 'Connection timed out after 20001 milliseconds')
Fetch error: http://www.zoomerang.com/ => https://www.zoomerang.com/: (60, 'SSL certificate problem: unable to get local issuer certificate')

the checker also reactivate default_off='failed ruleset test' ruleset but leaving the comment untouched, see also #10538 (comment)

Remove obsolete comments from re-activated rulesets
@zoracon
Copy link
Contributor

zoracon commented Sep 11, 2019

Closing for now, seems like this file structure is outdated

@zoracon zoracon closed this Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants