Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Create utils/full-rules-test.sh #11561

Closed
wants to merge 2 commits into from
Closed

Create utils/full-rules-test.sh #11561

wants to merge 2 commits into from

Conversation

cschanaj
Copy link
Collaborator

@cschanaj cschanaj commented Jul 31, 2017

it will somehow introduce false result, see #11560 should not be merged before #11998

ping @Hainish

# Undo whitelisting from `rules-test` if possible

# Change directory to git root; taken from ../test/test.sh
if [ -n "$GIT_DIR" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this file run? How does $GIT_DIR get set? Using something like git rev-parse --show-toplevel) to get the toplevel might make it easier to run this file since it won't depend of mysterious global variables.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I run this by calling ./utils/full-rules-test.sh in the root directory. It is taken from

# Get to the repo root directory, even when we're symlinked as a hook.

and honestly I do not know where does this variable come from 😄

@cowlicks
Copy link
Contributor

@cschanaj could you please describe the purpose of this PR? It isn't clear to me from the description.

@cschanaj
Copy link
Collaborator Author

cschanaj commented Sep 19, 2017

Currently, we use a whitelist (utils/ruleset-whitelist.csv) to exempt a number of ruleset from Travis test. For some reasons, there are false entries, i.e. we are whitelisting some ruleset unnecessarily (as they can pass the Travis without error). This script will remove false whitelisting for rules-test.

@Hainish
Copy link
Member

Hainish commented Sep 20, 2017

@cowlicks for additional context, any ruleset PR will run the fetch test on only the targets listed in that PR.

A more comprehensive full-fetch-test is something we periodically run, which

  1. re-enables all rulesets that have been previously disabled due to fetch test failures
  2. tests all enabled rulesets with the fetch test
  3. disables all rulesets which fail the fetch test

Here's the code: https://github.com/EFForg/https-everywhere-full-fetch-test

This is done as a batch job, and was run last on Jun 20.

@cschanaj cschanaj closed this Oct 29, 2017
@cschanaj cschanaj deleted the utils-full-rules-test branch October 29, 2017 09:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants