Skip Guard in IGF Solver (Revert #5284) #5335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts the inclusion of the guard cells when copying rho. We could not yet determine why, but with this change the FFT 3D solver in ImpactX does not converge to the analytical solutions anymore.
ax3l
added
bug
ax3l
force-pushed
the
revert-guards-igf
branch
from
0b3c33f
to
f1d78ca
Compare
RemiLehe
approved these changes
Sep 26, 2024
RemiLehe
added a commit
that referenced
this pull request
Nov 4, 2024
I forgot to update the comment in this PR: #5335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the inclusion of the guard cells when copying rho. We could not yet determine why, but with this change the FFT 3D solver in ImpactX does not converge to the analytical solutions anymore.
Reverts #5284
X-ref: ECP-WarpX/impactx#715 (comment)