Copy rho from guard cells in IGF solver #5284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeriforme
approved these changes
Sep 17, 2024
JustinRayAngus
pushed a commit
to LLNL/WarpX
that referenced
this pull request
Sep 18, 2024
* Copy rho from guard cells in IGF solver * Reset checksum
ax3l
added a commit
to ax3l/WarpX
that referenced
this pull request
Sep 26, 2024
This reverts the inclusion of the guard cells when copying rho. We could not yet determine why, but with this change the FFT 3D solver in ImpactX does not converge to the analytical solutions anymore.
RemiLehe
pushed a commit
that referenced
this pull request
Sep 26, 2024
* Skip Guard in IGF Solver (Revert #5284) This reverts the inclusion of the guard cells when copying rho. We could not yet determine why, but with this change the FFT 3D solver in ImpactX does not converge to the analytical solutions anymore. * Reset Checksum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In principle, rho from the guard cells should be taken into account in the IGF solver.
In practice, it should not make a big difference, because the IGF is meant to be used with open boundaries, in which case particles are usually not meant to be reaching the boundaries.