Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMReX/pyAMReX/PICSAR: Weekly Update #4881

Merged
merged 1 commit into from
Apr 23, 2024
Merged

AMReX/pyAMReX/PICSAR: Weekly Update #4881

merged 1 commit into from
Apr 23, 2024

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Apr 22, 2024

Weekly update to latest AMReX.
Weekly update to latest pyAMReX (no changes).
Weekly update to latest PICSAR (no changes).

./Tools/Release/updateAMReX.py
./Tools/Release/updatepyAMReX.py
./Tools/Release/updatePICSAR.py

@ax3l ax3l added the component: third party Changes in WarpX that reflect a change in a third-party library label Apr 22, 2024
@lucafedeli88
Copy link
Member

Tests are failing due to a recent change in the regtest.py script (https://github.com/AMReX-Codes/regression_testing/blame/c17887e4afabf83a56723d30899e13264439ba8b/regtest.py#L1213). The new logic checks for files matching the pattern re.match(f"{test.name}.*_(plt|chk)[0-9]+", pfile)) , and throws an error if no file is found. However, in WarpX tests, we don't always generate such files. In some cases the output consists in just reduced diagnostics, while in others it consists in OpenPMD files.

@ax3l
Copy link
Member Author

ax3l commented Apr 22, 2024

Thanks, Luca!

@zingale is there a way we could control this via an option?

@ax3l ax3l mentioned this pull request Apr 22, 2024
Open
roelof-groenewald
roelof-groenewald reviewed Apr 23, 2024
View reviewed changes
Copy link
Member

@roelof-groenewald roelof-groenewald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably get the CI test failures sorted before merging this to make sure all the tests would actually still pass.

@roelof-groenewald
Copy link
Member

It's interesting that the MacOS build isn't failing in this PR as it is for other PRs.

@ax3l
Copy link
Member Author

ax3l commented Apr 23, 2024 •
edited
Loading

Might be a half-propagated homebrew update that is still being rolled out.

roelof-groenewald
roelof-groenewald approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@roelof-groenewald roelof-groenewald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the tests are passing so we're good to go 🎉

@roelof-groenewald roelof-groenewald merged commit 8344f2c into ECP-WarpX:development Apr 23, 2024
45 checks passed
@ax3l ax3l deleted the topic-amrexWeekly branch April 29, 2024 16:31
Haavaan pushed a commit to Haavaan/WarpX that referenced this pull request Jun 5, 2024
@ax3l @Haavaan
AMReX: Weekly Update (ECP-WarpX#4881)
eb419de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roelof-groenewald roelof-groenewald roelof-groenewald approved these changes

Assignees

@roelof-groenewald roelof-groenewald

Labels
component: third party Changes in WarpX that reflect a change in a third-party library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ax3l @lucafedeli88 @roelof-groenewald