Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests now Fail w/o Plotfile Output #136

Open
ax3l opened this issue Apr 22, 2024 · 1 comment
Open

Tests now Fail w/o Plotfile Output #136

ax3l opened this issue Apr 22, 2024 · 1 comment
Labels
bug

Comments

@ax3l
Copy link
Member

ax3l commented Apr 22, 2024

WarpX broke from a recent change in #135
X-ref ECP-WarpX/WarpX#4881 (comment)

From @lucafedeli88

Tests are failing due to a recent change in the regtest.py script (https://github.com/AMReX-Codes/regression_testing/blame/c17887e4afabf83a56723d30899e13264439ba8b/regtest.py#L1213). The new logic checks for files matching the pattern re.match(f"{test.name}.*_(plt|chk)[0-9]+", pfile)) , and throws an error if no file is found. However, in WarpX tests, we don't always generate such files. In some cases the output consists in just reduced diagnostics, while in others it consists in OpenPMD files.
@ax3l ax3l added the bug label Apr 22, 2024
@ax3l ax3l mentioned this issue Apr 22, 2024
Merged
ax3l added a commit to ax3l/WarpX that referenced this issue Apr 22, 2024
@ax3l
Downgrade Reg Tests
3767e38 
Downgrade the regression testing scripts to work around
  AMReX-Codes/regression_testing#136
@ax3l ax3l mentioned this issue Apr 22, 2024
Merged
ax3l added a commit to ax3l/WarpX that referenced this issue Apr 22, 2024
@ax3l
Downgrade Reg Tests
cfd9710 
Downgrade the regression testing scripts to work around
  AMReX-Codes/regression_testing#136
ax3l added a commit to ax3l/WarpX that referenced this issue Apr 22, 2024
@ax3l
Downgrade Reg Tests
d6580f6 
Downgrade the regression testing scripts to work around
  AMReX-Codes/regression_testing#136
ax3l added a commit to ECP-WarpX/WarpX that referenced this issue Apr 22, 2024
@ax3l
Downgrade Reg Tests (#4882)
fc94b23 
Downgrade the regression testing scripts to work around
  AMReX-Codes/regression_testing#136
@lucafedeli88 lucafedeli88 mentioned this issue Apr 23, 2024
Merged
Haavaan pushed a commit to Haavaan/WarpX that referenced this issue Jun 5, 2024
@ax3l @Haavaan
Downgrade Reg Tests (ECP-WarpX#4882)
7384036 
Downgrade the regression testing scripts to work around
  AMReX-Codes/regression_testing#136
@zingale
Copy link
Member

zingale commented Jun 20, 2024

this has been made an option, so things should work now by default

@EZoni EZoni mentioned this issue Jul 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ax3l @zingale