-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMReX/PICSAR: Weekly Update #3822
Conversation
a few checks that raise checksum differences:
|
@WeiqunZhang I don't understand the relatively large changes in |
@ax3l This test does have particles, I think, since the laser is emitted by an antenna made of macroparticles with a prescribed motion. |
Oh I forgot again, ok that makes sense (including the rho). Should we print the fields before and after to see it still makes sense? There is a significantly larger change in the fields for this one, concerning me the antenna might have changed now or the box might be too small of the initialized laser in the test. |
Updating once more to include AMReX-Codes/amrex#3248 |
That test with the larger change in checksum (
and might be too small for the sim box. Don't really know what to make of it. @EZoni as main author of the test, what is the expected output it checks? :) https://github.com/ECP-WarpX/WarpX/commits/development/Examples/Tests/pml/inputs_3d |
In order to go forward, I would merge w/o the |
* AMReX: Weekly Update * AMReX: Include Fix Roundoff Domain 3247 * Reset Benchmarks * AMReX: Include PR 3248 * Update Checksums
Weekly update to latest AMReX.
Weekly update to latest PICSAR (no changes).
Notes